Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp - Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/crypto/CryptoResultImpl.cpp ('K') | « Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerRegistration.cpp » ('j') | Source/modules/webaudio/AudioContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

index 48effc9b452b86020aedbff976a03fbb31496103..3350331b19d80fb543acb5299d974e908c46478a 100644

--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

@@ -61,7 +61,7 @@ namespace blink {

class ServiceWorkerGlobalScope::SkipWaitingCallback final : public WebServiceWorkerSkipWaitingCallbacks {

WTF_MAKE_NONCOPYABLE(SkipWaitingCallback);

public:

- explicit SkipWaitingCallback(PassRefPtr<ScriptPromiseResolver> resolver)

+ explicit SkipWaitingCallback(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)

: m_resolver(resolver) { }

~SkipWaitingCallback() { }

@@ -71,7 +71,7 @@ public:

}

private:

- RefPtr<ScriptPromiseResolver> m_resolver;

+ RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;

};

PassRefPtrWillBeRawPtr<ServiceWorkerGlobalScope> ServiceWorkerGlobalScope::create(ServiceWorkerThread* thread, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData> startupData)

@@ -132,7 +132,7 @@ void ServiceWorkerGlobalScope::close(ExceptionState& exceptionState)

ScriptPromise ServiceWorkerGlobalScope::skipWaiting(ScriptState* scriptState)

{

- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

ExecutionContext* executionContext = scriptState->executionContext();