Source/modules/quota/StorageQuota.cpp - Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/quota/StorageQuota.cpp

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/crypto/CryptoResultImpl.cpp ('K') | « Source/modules/push_messaging/PushRegistrationCallbacks.cpp ('k') | Source/modules/quota/StorageQuotaCallbacksImpl.h » ('j') | Source/modules/webaudio/AudioContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/quota/StorageQuota.cpp

diff --git a/Source/modules/quota/StorageQuota.cpp b/Source/modules/quota/StorageQuota.cpp

index 6f9189c35b5ab6a91a105fc8d70f50fb1c924c74..7c98ac84b65119b10483d08ae4fdeaa2fd11cf38 100644

--- a/Source/modules/quota/StorageQuota.cpp

+++ b/Source/modules/quota/StorageQuota.cpp

@@ -84,7 +84,7 @@ Vector<String> StorageQuota::supportedTypes() const

ScriptPromise StorageQuota::queryInfo(ScriptState* scriptState, String type)

{

- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

SecurityOrigin* securityOrigin = scriptState->executionContext()->securityOrigin();

@@ -103,7 +103,7 @@ ScriptPromise StorageQuota::requestPersistentQuota(ScriptState* scriptState, uns

{

StorageQuotaClient* client = StorageQuotaClient::from(scriptState->executionContext());

if (!client) {

- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

resolver->reject(DOMError::create(NotSupportedError));

return promise;