Source/modules/push_messaging/PushPermissionStatusCallback.h - Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushPermissionStatusCallback.h

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WIP: 1st trial Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/crypto/CryptoResultImpl.cpp ('K') | « Source/modules/push_messaging/PushManager.cpp ('k') | Source/modules/push_messaging/PushPermissionStatusCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/push_messaging/PushPermissionStatusCallback.h

diff --git a/Source/modules/push_messaging/PushPermissionStatusCallback.h b/Source/modules/push_messaging/PushPermissionStatusCallback.h

index 58e3890fcf626cf944076707041c51d6b53f1d70..7d5c8066d8b858c593fe7640c2070929760408e1 100644

--- a/Source/modules/push_messaging/PushPermissionStatusCallback.h

+++ b/Source/modules/push_messaging/PushPermissionStatusCallback.h

@@ -24,7 +24,7 @@ class PushPermissionStatusCallback final : public WebPushPermissionStatusCallbac

WTF_MAKE_NONCOPYABLE(PushPermissionStatusCallback);

public:

- explicit PushPermissionStatusCallback(PassRefPtr<ScriptPromiseResolver>);

+ explicit PushPermissionStatusCallback(PassRefPtrWillBeRawPtr<ScriptPromiseResolver>);

virtual ~PushPermissionStatusCallback();

void onSuccess(WebPushPermissionStatus*) override;

@@ -34,7 +34,7 @@ public:

private:

static const WTF::String& permissionString(WebPushPermissionStatus);

- RefPtr<ScriptPromiseResolver> m_resolver;

+ RefPtrWillBeCrossThreadPersistent<ScriptPromiseResolver> m_resolver;

};

} // namespace blink