Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp - Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WIP: 1st trial Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/crypto/CryptoResultImpl.cpp ('K') | « Source/modules/encryptedmedia/MediaKeySystemAccess.cpp ('k') | Source/modules/geofencing/Geofencing.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp

diff --git a/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp b/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp

index 6fc6e6e84f0697ce5d7016093f9f3b4181b9e41b..9b8fdbf2b936bad466cffe936c20b05b57f45735 100644

--- a/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp

+++ b/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp

@@ -46,7 +46,7 @@ private:

blink::ScriptPromise MediaKeySystemAccessInitializer::create(blink::ScriptState* scriptState, const String& keySystem, const Vector<blink::MediaKeySystemConfiguration>& supportedConfigurations)

{

- RefPtr<MediaKeySystemAccessInitializer> initializer = adoptRef(new MediaKeySystemAccessInitializer(scriptState, keySystem, supportedConfigurations));

+ RefPtrWillBeRawPtr<MediaKeySystemAccessInitializer> initializer = adoptRefWillBeNoop(new MediaKeySystemAccessInitializer(scriptState, keySystem, supportedConfigurations));

initializer->suspendIfNeeded();

initializer->keepAliveWhilePending();

return initializer->promise();