Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-release-noreference.html

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeys-with-session.html ('K') | « LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-release.html ('k') | LayoutTests/media/encrypted-media/encrypted-media-lifetime-multiple-mediakeys.html » ('j') | Source/bindings/core/v8/ScriptPromiseResolver.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <title>Test MediaKeySession lifetime after release() without references< /title> 4 <title>Test MediaKeySession lifetime after release() without references< /title>
5 <script src="encrypted-media-utils.js"></script> 5 <script src="encrypted-media-utils.js"></script>
6 <script src="../../resources/testharness.js"></script> 6 <script src="../../resources/testharness.js"></script>
7 <script src="../../resources/testharnessreport.js"></script> 7 <script src="../../resources/testharnessreport.js"></script>
8 </head> 8 </head>
9 <body> 9 <body>
10 <div id="log"></div> 10 <div id="log"></div>
(...skipping 18 matching lines...) Expand all
29 // Create 2 sessions. 29 // Create 2 sessions.
30 var mediaKeys; 30 var mediaKeys;
31 var mediaKeySession1; 31 var mediaKeySession1;
32 var mediaKeySession2; 32 var mediaKeySession2;
33 navigator.requestMediaKeySystemAccess('org.w3.clearkey').then(fu nction(access) { 33 navigator.requestMediaKeySystemAccess('org.w3.clearkey').then(fu nction(access) {
34 return access.createMediaKeys(); 34 return access.createMediaKeys();
35 }).then(function(result) { 35 }).then(function(result) {
36 mediaKeys = result; 36 mediaKeys = result;
37 37
38 // Verify MediaKeys are not an ActiveDOMObject. 38 // Verify MediaKeys are not an ActiveDOMObject.
39 assert_equals(numActiveDOMObjectsCreated(), 0, 'MediaKeys.cr eate()'); 39 // MediaKeys are not an ActiveDOMObject, but when creating M ediaKeys,
40 // creating ScriptPromiseResolvers, which are ActiveDOMObjec ts.
41 // so numActiveDOMObjetsCreated() <= 2 (1 is MediaKeysInitia lizer and
42 // the other is MediaKeySystemAccessInitializer).
43 // When enabling oilpan, the ScriptPromiseResolvers are not destroyed
44 // immediately. So numActiveDOMObjectsCreate() <= 2.
45 assert_less_than_equal(numActiveDOMObjectsCreated(), 2, 'Med iaKeys.create()');
40 46
41 mediaKeySession1 = mediaKeys.createSession(); 47 mediaKeySession1 = mediaKeys.createSession();
42 return mediaKeySession1.generateRequest(initDataType, initDa ta); 48 return mediaKeySession1.generateRequest(initDataType, initDa ta);
43 }).then(function() { 49 }).then(function() {
44 assert_true(mediaKeySession1.sessionId && mediaKeySession1.s essionId.length > 0); 50 assert_true(mediaKeySession1.sessionId && mediaKeySession1.s essionId.length > 0);
45 // Should be 1 MediaKeySession. 51 // Should be 1 MediaKeySession.
46 assert_equals(numActiveDOMObjectsCreated(), 1, 'mediaKeys.cr eateSession(1)'); 52 // numActiveDOMObjectsCreated() <= 4 (1 is a ScriptPromiseRe solver owned by
53 // ContentDecryptionModuleResultPromise and the other is Med iaKeySession).
54 assert_less_than_equal(numActiveDOMObjectsCreated(), 4, 'Med iaKeys.createSession(1)');
47 mediaKeySession2 = mediaKeys.createSession(); 55 mediaKeySession2 = mediaKeys.createSession();
48 return mediaKeySession2.generateRequest(initDataType, initDa ta); 56 return mediaKeySession2.generateRequest(initDataType, initDa ta);
49 }).then(function() { 57 }).then(function() {
50 assert_true(mediaKeySession2.sessionId && mediaKeySession2.s essionId.length > 0); 58 assert_true(mediaKeySession2.sessionId && mediaKeySession2.s essionId.length > 0);
51 // Should be 2 MediaKeySessions. 59 // Should be 2 MediaKeySessions.
52 assert_equals(numActiveDOMObjectsCreated(), 2, 'mediaKeys.cr eateSession(2)'); 60 // numActiveDOMObjectsCreated() <= 6 (ditto)
61 assert_less_than_equal(numActiveDOMObjectsCreated(), 6, 'med iaKeys.createSession(2)');
53 }).then(function(result) { 62 }).then(function(result) {
54 // Run gc(). All sessions should remain as we have a 63 // Run gc(). All sessions should remain as we have a
55 // reference to each one. 64 // reference to each one.
56 return createGCPromise(); 65 return createGCPromise();
57 }).then(function(result) { 66 }).then(function(result) {
58 // Should be just the 2 MediaKeySessions. 67 // Should be just the 2 MediaKeySessions.
59 assert_equals(numActiveDOMObjectsCreated(), 2, 'After gc()') ; 68 assert_equals(numActiveDOMObjectsCreated(), 2, 'After gc()') ;
60 69
61 // Close the sessions. Once the close() event is received, 70 // Close the sessions. Once the close() event is received,
62 // they should get garbage collected as there are no JS 71 // they should get garbage collected as there are no JS
(...skipping 23 matching lines...) Expand all
86 assert_equals(numActiveDOMObjectsCreated(), 0); 95 assert_equals(numActiveDOMObjectsCreated(), 0);
87 assert_not_equals(mediaKeys, null); 96 assert_not_equals(mediaKeys, null);
88 test.done(); 97 test.done();
89 }).catch(function(error) { 98 }).catch(function(error) {
90 forceTestFailureFromPromise(test, error); 99 forceTestFailureFromPromise(test, error);
91 }); 100 });
92 }, 'MediaKeySession lifetime after release() without references'); 101 }, 'MediaKeySession lifetime after release() without references');
93 </script> 102 </script>
94 </body> 103 </body>
95 </html> 104 </html>
OLDNEW
« LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeys-with-session.html ('K') | « LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-release.html ('k') | LayoutTests/media/encrypted-media/encrypted-media-lifetime-multiple-mediakeys.html » ('j') | Source/bindings/core/v8/ScriptPromiseResolver.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698