Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: src/liveedit.cc

Issue 7834018: Support compaction for code space pages. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: port changes from ia32 to arm & x64 Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/liveedit.cc
diff --git a/src/liveedit.cc b/src/liveedit.cc
index f6e18f6090cca2b722d95fa77ddcbc734ec2672e..8b8629b091b5d4b9281bfa3713bdff5bdd904193 100644
--- a/src/liveedit.cc
+++ b/src/liveedit.cc
@@ -981,9 +981,7 @@ class ReferenceCollectorVisitor : public ObjectVisitor {
}
Address substitution_entry = substitution->instruction_start();
for (int i = 0; i < reloc_infos_.length(); i++) {
- reloc_infos_[i].set_target_address(substitution_entry, NULL);
- substitution->GetHeap()->incremental_marking()->RecordWriteOf(
- substitution);
+ reloc_infos_[i].set_target_address(substitution_entry);
}
for (int i = 0; i < code_entries_.length(); i++) {
Address entry = code_entries_[i];
@@ -1418,7 +1416,7 @@ void LiveEdit::ReplaceRefToNestedFunction(
for (RelocIterator it(parent_shared->code()); !it.done(); it.next()) {
if (it.rinfo()->rmode() == RelocInfo::EMBEDDED_OBJECT) {
if (it.rinfo()->target_object() == *orig_shared) {
- it.rinfo()->set_target_object(*subst_shared, NULL);
+ it.rinfo()->set_target_object(*subst_shared);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698