Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 783393006: Remove relayout due to scrollbars taking up width (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
Reviewers:
esprehn, rafaelw, eseidel
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove relayout due to scrollbars taking up width We only have overlay scrollbars, so we never need to relayout due to the lack or presence of scrollbars. Also remove a few stracking has*Scrollbar methods. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0276d1da2936c26a4b06d0ddd81b81407c927bdd

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -91 lines) Patch
M sky/engine/core/rendering/RenderLayerScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 4 chunks +16 lines, -57 lines 1 comment Download
M sky/engine/public/web/WebFrame.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eseidel
lgtm
6 years ago (2014-12-10 03:40:38 UTC) #3
ojan
https://codereview.chromium.org/783393006/diff/1/sky/engine/core/rendering/RenderLayerScrollableArea.cpp File sky/engine/core/rendering/RenderLayerScrollableArea.cpp (right): https://codereview.chromium.org/783393006/diff/1/sky/engine/core/rendering/RenderLayerScrollableArea.cpp#newcode418 sky/engine/core/rendering/RenderLayerScrollableArea.cpp:418: setHasHorizontalScrollbar(hasHorizontalOverflow); These already have the hasHorizontalScrollbar() != hasHorizontalOverflow check, ...
6 years ago (2014-12-10 03:40:38 UTC) #4
ojan
6 years ago (2014-12-10 03:48:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0276d1da2936c26a4b06d0ddd81b81407c927bdd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698