Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 783393004: Revert of Replace EncodeBitmap with an interface. (Closed)

Created:
6 years ago by scroggo
Modified:
6 years ago
Reviewers:
rmistry, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Replace EncodeBitmap with an interface. (patchset #12 id:210001 of https://codereview.chromium.org/784643002/) Reason for revert: Failing serialization tasks in DM: http://build.chromium.org/p/client.skia/builders/Test-Win8-ShuttleA-GTX660-x86-Debug/builds/352/steps/dm/logs/stdio Original issue's description: > Replace EncodeBitmap with an interface. > > Gives more flexibility to the caller to decide whether to use the > encoded data returned by refEncodedData(). > > Provides an implementation that supports the old version of > SkPicture::serialize(). > > TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely > > BUG=skia:3190 > > Committed: https://skia.googlesource.com/skia/+/0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1 > > Committed: https://skia.googlesource.com/skia/+/02b217f80b01a7dda8493422e5257c36a9ce8464 TBR=reed@google.com,rmistry@google.com NOTREECHECKS=true NOTRY=true BUG=skia:3190 Committed: https://skia.googlesource.com/skia/+/303044579913eacc177d4b28a674121725c565bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -206 lines) Patch
M dm/DMSerializeTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gmmain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkPicture.h View 3 chunks +2 lines, -20 lines 0 comments Download
D include/core/SkPixelSerializer.h View 1 chunk +0 lines, -52 lines 0 comments Download
M include/core/SkWriteBuffer.h View 3 chunks +10 lines, -14 lines 0 comments Download
M src/core/SkPicture.cpp View 3 chunks +3 lines, -36 lines 0 comments Download
M src/core/SkPictureData.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkPictureData.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkWriteBuffer.cpp View 5 chunks +31 lines, -38 lines 0 comments Download
M tests/PictureTest.cpp View 3 chunks +4 lines, -18 lines 0 comments Download
M tools/PictureRenderer.cpp View 3 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Created Revert of Replace EncodeBitmap with an interface.
6 years ago (2014-12-09 16:26:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783393004/1
6 years ago (2014-12-09 16:27:28 UTC) #2
commit-bot: I haz the power
6 years ago (2014-12-09 16:27:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/303044579913eacc177d4b28a674121725c565bb

Powered by Google App Engine
This is Rietveld 408576698