Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 783393002: IDB: Remove unused variable IndexedDBInfo::path_ (Closed)

Created:
6 years ago by sagarmittal
Modified:
6 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, cmumford, dgrogan, markusheintz_, jsbell+idb_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

IDB: Remove unused variable IndexedDBInfo::path_ R=cmumford@chromium.org Committed: https://crrev.com/4d13d44bc12f626eb7e63b7c6842ea45bba3b1c6 Cr-Commit-Position: refs/heads/master@{#308007}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix calls from chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc #

Patch Set 4 : Fix cookie_details_unittest.mm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details_unittest.mm View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/indexed_db_info.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/public/browser/indexed_db_info.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (11 generated)
sagarmittal
6 years ago (2014-12-09 00:52:51 UTC) #1
jsbell
We may want to dig up why this was in there. Perhaps it was displayed ...
6 years ago (2014-12-09 00:59:54 UTC) #3
cmumford
lgtm It looks like this was added in https://crrev.com/14156003 (f2431ad6) and path_ was used in ...
6 years ago (2014-12-09 16:10:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783393002/1
6 years ago (2014-12-09 21:34:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/29220)
6 years ago (2014-12-09 21:39:01 UTC) #8
sagarmittal
Looks like I need an LGTM from an owner -- any suggestions?
6 years ago (2014-12-10 01:46:19 UTC) #9
dgrogan
jam, can you review as owner of content/ ? michaeln, can you review as owner ...
6 years ago (2014-12-10 03:32:12 UTC) #11
jam
lgtm
6 years ago (2014-12-10 17:53:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783393002/1
6 years ago (2014-12-10 21:13:33 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/102561) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/92527) win_gpu ...
6 years ago (2014-12-10 21:17:30 UTC) #16
jsbell
On 2014/12/10 21:17:30, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years ago (2014-12-10 21:26:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783393002/20001
6 years ago (2014-12-10 22:07:21 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/97089) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/29695) android_dbg_tests_recipe ...
6 years ago (2014-12-10 22:39:49 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783393002/40001
6 years ago (2014-12-10 23:21:30 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/6192)
6 years ago (2014-12-11 01:27:37 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-12 00:20:55 UTC) #27
commit-bot: I haz the power
6 years ago (2014-12-12 00:21:42 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4d13d44bc12f626eb7e63b7c6842ea45bba3b1c6
Cr-Commit-Position: refs/heads/master@{#308007}

Powered by Google App Engine
This is Rietveld 408576698