pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart - Issue 783383003: code completion for dynamic type elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

Issue 783383003: code completion for dynamic type elements (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart ('k') | pkg/analysis_server/test/completion_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

index dd313e132beccc38753ec5aa1ce2c09020ea8a9a..2c5a4e2f1549a58104f8ff58ad14048584a8245e 100644

--- a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

+++ b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

@@ -196,6 +196,9 @@ class ClassElementSuggestionBuilder extends _AbstractSuggestionBuilder {

static void suggestionsFor(DartCompletionRequest request, Element element,

{bool staticOnly: false}) {

+ if (element == DynamicElementImpl.instance) {

+ element = request.cache.objectClassElement;

+ }

if (element is ClassElement) {

return element.accept(

new ClassElementSuggestionBuilder(request, staticOnly));