Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 783203002: Add --content-shell-host-window-size switch to control the window size for content_shell. (Closed)

Created:
6 years ago by arunprasadr
Modified:
5 years, 10 months ago
Reviewers:
Mike West, pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a command line switch to control the window size of content_shell. This CL introduces a command line switch "--content-shell-host-window-size" to help the developers to specify the content_shell size for windowless ozone platforms like test, egltest, dri, caca. Prior to this CL, the developer has to change the constants(kDefaultTestWindowWidthDip, kDefaultTestWindowHeightDip) in shell.cc to increase the content_shell resolution for above mentioned ozone platforms. Committed: https://crrev.com/168b0ac2ed4f8fb818f0ad9fcfa1f2177f94fb9d Cr-Commit-Position: refs/heads/master@{#308391}

Patch Set 1 : Initial CL #

Patch Set 2 : Fix typo in function name #

Patch Set 3 : Rename commandline switch as per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M content/shell/browser/shell.cc View 1 2 2 chunks +22 lines, -3 lines 0 comments Download
M content/shell/common/shell_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/common/shell_switches.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
arunprasadr
PTAL
6 years ago (2014-12-08 17:53:47 UTC) #2
arunprasadr
On 2014/12/08 17:53:47, arurajku wrote: > PTAL Please ignore the typo in function name ("ShellShellSize")
6 years ago (2014-12-08 17:57:48 UTC) #3
arunprasadr
Uploaded a new CL with proper function name. PTAL. Thanks.
6 years ago (2014-12-08 18:06:45 UTC) #4
Mike West
Why do you need this functionality? Could you either link to a bug, expand the ...
6 years ago (2014-12-09 08:36:11 UTC) #6
arunprasadr
On 2014/12/09 08:36:11, Mike West wrote: > Why do you need this functionality? Could you ...
6 years ago (2014-12-10 04:42:25 UTC) #7
Mike West
LGTM, but I'd change the flag from "bounds" to "size". "Bounds", to me, implies position ...
6 years ago (2014-12-15 08:39:35 UTC) #8
arunprasadr
@Mike, Thanks for your review comments. Uploaded a new CL with different switch name(--content-shell-host-window-size). PTAL. ...
6 years ago (2014-12-15 12:03:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783203002/40001
6 years ago (2014-12-15 17:37:10 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-15 19:36:35 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-15 19:37:23 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/168b0ac2ed4f8fb818f0ad9fcfa1f2177f94fb9d
Cr-Commit-Position: refs/heads/master@{#308391}

Powered by Google App Engine
This is Rietveld 408576698