Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 783183003: Use EXPECT_FLOAT_EQ for points equality test. (Closed)

Created:
6 years ago by hush (inactive)
Modified:
6 years ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, rmcilroy, Sami
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use EXPECT_FLOAT_EQ for points equality test. Using EXPECT_EQ to compare the points is too strict and fails on arm64. Use EXPECT_FLOAT_EQ instead, which is slightly relaxed. BUG=439927 Committed: https://crrev.com/d484d45513b5d1460c77fb1e9c1222d620b43abb Cr-Commit-Position: refs/heads/master@{#307402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M cc/quads/draw_polygon_unittest.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
hush (inactive)
PTAL! Caused by https://codereview.chromium.org/774763004/ It turned out the comparison (EXPECT_EQ) is too strict for arm64. ...
6 years ago (2014-12-08 20:04:12 UTC) #2
danakj
LGTM
6 years ago (2014-12-08 20:28:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783183003/1
6 years ago (2014-12-09 01:32:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-09 02:14:56 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-09 02:17:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d484d45513b5d1460c77fb1e9c1222d620b43abb
Cr-Commit-Position: refs/heads/master@{#307402}

Powered by Google App Engine
This is Rietveld 408576698