Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6753)

Unified Diff: chrome/renderer/content_settings_observer.h

Issue 7831075: Delegating the "are images allowed" decision to renderer. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Doc fix. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/chrome_render_process_observer.cc ('k') | chrome/renderer/content_settings_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/content_settings_observer.h
diff --git a/chrome/renderer/content_settings_observer.h b/chrome/renderer/content_settings_observer.h
index 45f2125a1b9e88a800a36e89ed1fbe7a0a77348d..3055caa878e08290648a2cdcdcf2423aeac55fa1 100644
--- a/chrome/renderer/content_settings_observer.h
+++ b/chrome/renderer/content_settings_observer.h
@@ -27,14 +27,19 @@ class ContentSettingsObserver
explicit ContentSettingsObserver(content::RenderView* render_view);
virtual ~ContentSettingsObserver();
- // Sets the content settings that back allowScripts(), allowImages(), and
- // allowPlugins().
+ // Sets the content settings that back allowScripts() and allowPlugins().
void SetContentSettings(const ContentSettings& settings);
- // Sets the default content settings that back allowScripts(),
- // allowImages(), and allowPlugins().
+ // Sets the default content settings that back allowScripts() and
+ // allowPlugins().
static void SetDefaultContentSettings(const ContentSettings& settings);
+ // Sets the image setting rules which back |allowImage()|. The
+ // |ContentSettingsForOneType| object must outlive this
+ // |ContentSettingsObserver|.
+ void SetImageSettingRules(
+ const ContentSettingsForOneType* image_setting_rules);
+
// Returns the setting for the given type.
ContentSetting GetContentSetting(ContentSettingsType type);
@@ -90,11 +95,17 @@ class ContentSettingsObserver
HostContentSettings host_content_settings_;
// Stores our most up-to-date view of the default content settings.
+ // TODO(marja): Store default settings in |ChromeRenderProcessObserver|.
static ContentSettings default_settings_;
- // Stores if loading of images, scripts, and plugins is allowed.
+ // Stores if loading of scripts and plugins is allowed.
ContentSettings current_content_settings_;
+ // Stores the rules for image content settings. Normally, they are owned by
+ // |ChromeRenderProcessObserver|; in the tests they are owned by the caller of
+ // |SetImageSettingRules|.
+ const ContentSettingsForOneType* image_setting_rules_;
+
// Stores if images, scripts, and plugins have actually been blocked.
bool content_blocked_[CONTENT_SETTINGS_NUM_TYPES];
« no previous file with comments | « chrome/renderer/chrome_render_process_observer.cc ('k') | chrome/renderer/content_settings_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698