Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3845)

Unified Diff: chrome/browser/content_settings/host_content_settings_map.h

Issue 7831075: Delegating the "are images allowed" decision to renderer. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Doc fix. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/host_content_settings_map.h
diff --git a/chrome/browser/content_settings/host_content_settings_map.h b/chrome/browser/content_settings/host_content_settings_map.h
index 4c167b991bfc1c529845b686eb13419db7fcda20..4980656ab277dcd1619e432a72a1c75743bf5464 100644
--- a/chrome/browser/content_settings/host_content_settings_map.h
+++ b/chrome/browser/content_settings/host_content_settings_map.h
@@ -49,15 +49,6 @@ class HostContentSettingsMap
NUM_PROVIDER_TYPES,
};
- // TODO(markusheintz): I sold my soul to the devil on order to add this tuple.
- // I really want my soul back, so I really will change this ASAP.
- typedef Tuple5<ContentSettingsPattern,
- ContentSettingsPattern,
- ContentSetting,
- std::string,
- bool> PatternSettingSourceTuple;
- typedef std::vector<PatternSettingSourceTuple> SettingsForOneType;
-
HostContentSettingsMap(PrefService* prefs,
ExtensionService* extension_service,
bool incognito);
@@ -126,16 +117,13 @@ class HostContentSettingsMap
const GURL& secondary_url) const;
// For a given content type, returns all patterns with a non-default setting,
- // mapped to their actual settings, in lexicographical order. |settings|
- // must be a non-NULL outparam. If this map was created for the
- // incognito profile, it will only return those settings differing from
- // the main map. For ContentSettingsTypes that require an resource identifier
- // to be specified, the |resource_identifier| must be non-empty.
+ // mapped to their actual settings, in the precedence order of the rules.
+ // |settings| must be a non-NULL outparam.
//
// This may be called on any thread.
void GetSettingsForOneType(ContentSettingsType content_type,
const std::string& resource_identifier,
- SettingsForOneType* settings) const;
+ ContentSettingsForOneType* settings) const;
// Sets the default setting for a particular content type. This method must
// not be invoked on an incognito map.
@@ -236,7 +224,7 @@ class HostContentSettingsMap
ProviderType provider_type,
ContentSettingsType content_type,
const std::string& resource_identifier,
- SettingsForOneType* settings,
+ ContentSettingsForOneType* settings,
bool incognito) const;
// Weak; owned by the Profile.
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/content_settings/host_content_settings_map.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698