Delegating the "are images allowed" decision to renderer.

chrome/renderer/content_settings_observer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_CONTENT_SETTINGS_OBSERVER_H_
 #define CHROME_RENDERER_CONTENT_SETTINGS_OBSERVER_H_
 #pragma once
 
 #include <map>
 
 #include "chrome/common/content_settings.h"
 #include "content/public/renderer/render_view_observer.h"
 #include "content/public/renderer/render_view_observer_tracker.h"
 
 class GURL;
 
 namespace WebKit {
 class WebSecurityOrigin;
 class WebURL;
 }
 
 // Handles blocking content per content settings for each RenderView.
 class ContentSettingsObserver
     : public content::RenderViewObserver,
       public content::RenderViewObserverTracker<ContentSettingsObserver> {
  public:
   explicit ContentSettingsObserver(content::RenderView* render_view);
   virtual ~ContentSettingsObserver();
 
-  // Sets the content settings that back allowScripts(), allowImages(), and
-  // allowPlugins().
+  // Sets the content settings that back allowScripts() and allowPlugins().
   void SetContentSettings(const ContentSettings& settings);
 
-  // Sets the default content settings that back allowScripts(),
-  // allowImages(), and allowPlugins().
+  // Sets the default content settings that back allowScripts() and
+  // allowPlugins().
   static void SetDefaultContentSettings(const ContentSettings& settings);
 
+  // Sets the image setting rules which back |allowImage()|.
+  // |ContentSettingObserver| does not take the ownership of the

[Bernhard Bauer, 2011/10/20 09:21:53]

Nit: Can you add a comment that state that callers should make sure the passed
|ContentSettingsForOneType*| outlives this object?

OTOH, stating that the method does *not* take ownership is not something we
usually document (we only document if it does).

[marja, 2011/10/20 11:44:22]

Done.

+  // pointer.
+  void SetImageSettingRules(
+      const ContentSettingsForOneType* image_setting_rules);
+
   // Returns the setting for the given type.
   ContentSetting GetContentSetting(ContentSettingsType type);
 
   bool plugins_temporarily_allowed() {
     return plugins_temporarily_allowed_;
   }
 
   // Sends an IPC notification that the specified content type was blocked.
   // If the content type requires it, |resource_identifier| names the specific
   // resource that was blocked (the plugin path in the case of plugins),
@@ skipping 35 matching lines @@
   // |content_type|.
   bool AllowContentType(ContentSettingsType settings_type);
 
   // Resets the |content_blocked_| array.
   void ClearBlockedContentSettings();
 
   typedef std::map<GURL, ContentSettings> HostContentSettings;
   HostContentSettings host_content_settings_;
 
   // Stores our most up-to-date view of the default content settings.
+  // TODO(marja): Store default settings in |ChromeRenderProcessObserver|.
   static ContentSettings default_settings_;
 
-  // Stores if loading of images, scripts, and plugins is allowed.
+  // Stores if loading of scripts and plugins is allowed.
   ContentSettings current_content_settings_;
 
+  // Stores the rules for image content settings. Normally, they are owned by
+  // |ChromeRenderProcessObserver|; in the tests they are owned by the caller of
+  // |SetImageSettingRules|.
+  const ContentSettingsForOneType* image_setting_rules_;
+
   // Stores if images, scripts, and plugins have actually been blocked.
   bool content_blocked_[CONTENT_SETTINGS_NUM_TYPES];
 
   // Caches the result of AllowStorage.
   typedef std::pair<GURL, bool> StoragePermissionsKey;
   std::map<StoragePermissionsKey, bool> cached_storage_permissions_;
 
   bool plugins_temporarily_allowed_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentSettingsObserver);
 };
 
 #endif  // CHROME_RENDERER_CONTENT_SETTINGS_OBSERVER_H_