runtime/vm/intermediate_language_arm64.cc - Issue 783103003: Clobber non-live temporaries on some paths involving a possible slow-path allocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_arm64.cc

Issue 783103003: Clobber non-live temporaries on some paths involving a possible slow-path allocation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: only clobber on slow path Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_arm64.cc

diff --git a/runtime/vm/intermediate_language_arm64.cc b/runtime/vm/intermediate_language_arm64.cc

index fedbd340f9e7ad6df3a9273cfb441a62132c29d1..d185d9e55dffb0d362bf2c65f4bb6e360bb770ae 100644

--- a/runtime/vm/intermediate_language_arm64.cc

+++ b/runtime/vm/intermediate_language_arm64.cc

@@ -1870,6 +1870,9 @@ void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

locs()->live_registers()->Add(locs()->in(1));

}

+ // Manually preserve temp which could be clobbered on the slow path.

+ locs()->live_registers()->Add(locs()->temp(0));

{

__ Bind(&store_double);

EnsureMutableBox(compiler,

« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')