Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: runtime/vm/intermediate_language_arm64.cc

Issue 783103003: Clobber non-live temporaries on some paths involving a possible slow-path allocation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: only clobber on slow path Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1852 matching lines...) Expand 10 before | Expand all | Expand 10 after
1863 __ b(&store_float64x2, EQ); 1863 __ b(&store_float64x2, EQ);
1864 1864
1865 // Fall through. 1865 // Fall through.
1866 __ b(&store_pointer); 1866 __ b(&store_pointer);
1867 1867
1868 if (!compiler->is_optimizing()) { 1868 if (!compiler->is_optimizing()) {
1869 locs()->live_registers()->Add(locs()->in(0)); 1869 locs()->live_registers()->Add(locs()->in(0));
1870 locs()->live_registers()->Add(locs()->in(1)); 1870 locs()->live_registers()->Add(locs()->in(1));
1871 } 1871 }
1872 1872
1873 // Manually preserve temp which could be clobbered on the slow path.
1874 locs()->live_registers()->Add(locs()->temp(0));
1875
1873 { 1876 {
1874 __ Bind(&store_double); 1877 __ Bind(&store_double);
1875 EnsureMutableBox(compiler, 1878 EnsureMutableBox(compiler,
1876 this, 1879 this,
1877 temp, 1880 temp,
1878 compiler->double_class(), 1881 compiler->double_class(),
1879 instance_reg, 1882 instance_reg,
1880 offset_in_bytes_, 1883 offset_in_bytes_,
1881 temp2); 1884 temp2);
1882 __ LoadDFieldFromOffset(VTMP, value_reg, Double::value_offset(), PP); 1885 __ LoadDFieldFromOffset(VTMP, value_reg, Double::value_offset(), PP);
(...skipping 3708 matching lines...) Expand 10 before | Expand all | Expand 10 after
5591 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs()); 5594 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
5592 #if defined(DEBUG) 5595 #if defined(DEBUG)
5593 __ LoadImmediate(R4, kInvalidObjectPointer, kNoPP); 5596 __ LoadImmediate(R4, kInvalidObjectPointer, kNoPP);
5594 __ LoadImmediate(R5, kInvalidObjectPointer, kNoPP); 5597 __ LoadImmediate(R5, kInvalidObjectPointer, kNoPP);
5595 #endif 5598 #endif
5596 } 5599 }
5597 5600
5598 } // namespace dart 5601 } // namespace dart
5599 5602
5600 #endif // defined TARGET_ARCH_ARM64 5603 #endif // defined TARGET_ARCH_ARM64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698