Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 783083002: Add support for child accounts. (Closed)

Created:
6 years ago by Marc Treib
Modified:
6 years ago
CC:
chromium-reviews, rginda+watch_chromium.org, pam+watch_chromium.org, Patrick Nepper
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add support for child accounts. This CL adds a service to detect and handle child accounts (by configuring the SupervisedUserService), as well as a class that fetches information about the child's family. TBRing since this has already been reviewed at https://chromereviews.googleplex.com/107687013/ TBR=bauerb@chromium.org TBR=noms@chromium.org BUG=372381 Committed: https://crrev.com/f813dfcef7889f57c3b1558e62012a438d9fc0a1 Cr-Commit-Position: refs/heads/master@{#307222}

Patch Set 1 #

Patch Set 2 : remove CrOS for now #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1272 lines, -6 lines) Patch
M chrome/browser/profiles/profile_manager.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/supervised_user/child_accounts/child_account_service.h View 1 chunk +93 lines, -0 lines 0 comments Download
A chrome/browser/supervised_user/child_accounts/child_account_service.cc View 1 1 chunk +308 lines, -0 lines 2 comments Download
A chrome/browser/supervised_user/child_accounts/child_account_service_factory.h View 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/supervised_user/child_accounts/child_account_service_factory.cc View 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/browser/supervised_user/child_accounts/family_info_fetcher.h View 1 chunk +132 lines, -0 lines 0 comments Download
A chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc View 1 chunk +317 lines, -0 lines 0 comments Download
A chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc View 1 chunk +322 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_settings_service.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783083002/1
6 years ago (2014-12-08 08:49:12 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/5414)
6 years ago (2014-12-08 09:48:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783083002/20001
6 years ago (2014-12-08 10:03:42 UTC) #6
Bernhard Bauer
https://codereview.chromium.org/783083002/diff/20001/chrome/browser/supervised_user/child_accounts/child_account_service.cc File chrome/browser/supervised_user/child_accounts/child_account_service.cc (right): https://codereview.chromium.org/783083002/diff/20001/chrome/browser/supervised_user/child_accounts/child_account_service.cc#newcode298 chrome/browser/supervised_user/child_accounts/child_account_service.cc:298: // user_manager::User* user = Can you remove this instead ...
6 years ago (2014-12-08 10:55:20 UTC) #8
Marc Treib
https://codereview.chromium.org/783083002/diff/20001/chrome/browser/supervised_user/child_accounts/child_account_service.cc File chrome/browser/supervised_user/child_accounts/child_account_service.cc (right): https://codereview.chromium.org/783083002/diff/20001/chrome/browser/supervised_user/child_accounts/child_account_service.cc#newcode298 chrome/browser/supervised_user/child_accounts/child_account_service.cc:298: // user_manager::User* user = On 2014/12/08 10:55:20, Bernhard Bauer ...
6 years ago (2014-12-08 10:58:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783083002/20001
6 years ago (2014-12-08 11:01:12 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-08 11:26:40 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f813dfcef7889f57c3b1558e62012a438d9fc0a1 Cr-Commit-Position: refs/heads/master@{#307222}
6 years ago (2014-12-08 11:27:27 UTC) #14
Marc Treib
6 years ago (2014-12-08 12:47:10 UTC) #16
Message was sent while issue was closed. 
Adding TBRed reviewers as actual reviewers, just fyi.

Powered by Google App Engine
This is Rietveld 408576698