content/browser/renderer_host/render_view_host_delegate.h - Issue 78303005: ContentSettings API should not interact with <webview>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_delegate.h

Issue 78303005: ContentSettings API should not interact with <webview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/content_settings_observer.cc ('K') | « chrome/test/data/extensions/platform_apps/web_view/shim/main.js ('k') | content/browser/renderer_host/render_view_host_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_delegate.h

diff --git a/content/browser/renderer_host/render_view_host_delegate.h b/content/browser/renderer_host/render_view_host_delegate.h

index f3bf8aafeada1199f5bb4427b0e4c502a1b4e0b1..69650f4e291a9dfbb8e7022d31af874a81df9b22 100644

--- a/content/browser/renderer_host/render_view_host_delegate.h

+++ b/content/browser/renderer_host/render_view_host_delegate.h

@@ -451,6 +451,10 @@ class CONTENT_EXPORT RenderViewHostDelegate {

// created by the RenderViewHost.

virtual FrameTree* GetFrameTree();

+ // Indicates whether the RenderViewHostDelegate is associated with a guest

+ // renderer process.

+ virtual bool IsGuest() const;

jochen (gone - plz use gerrit) 2013/12/03 08:55:21 why is this on RVHD? I would expect this on RPH?

Fady Samuel 2013/12/03 15:31:27 Oops, this is unnecessary code I added while tryin

protected:

virtual ~RenderViewHostDelegate() {}

};