chrome/renderer/content_settings_observer.cc - Issue 78303005: ContentSettings API should not interact with <webview>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/content_settings_observer.cc

Issue 78303005: ContentSettings API should not interact with <webview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplified patch according to comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_content_browser_client.cc ('K') | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/test/data/extensions/platform_apps/web_view/extension_api/content_script/README » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/content_settings_observer.cc

diff --git a/chrome/renderer/content_settings_observer.cc b/chrome/renderer/content_settings_observer.cc

index 4f0a4b253f05bdcb0d57d30bdfa061cb403af105..810998441534ececef58062270d9db8663875634 100644

--- a/chrome/renderer/content_settings_observer.cc

+++ b/chrome/renderer/content_settings_observer.cc

@@ -61,7 +61,6 @@ ContentSetting GetContentSettingFromRules(

return it->setting;

}

- NOTREACHED();

Charlie Reis 2013/11/27 17:35:55 Why is this changing?

return CONTENT_SETTING_DEFAULT;

jochen (gone - plz use gerrit) 2013/11/28 22:23:30 DEFAULT is just a placeholder value, we should nev

}