ContentSettings API should not interact with <webview>

chrome/browser/guestview/guestview.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/guestview/guestview.h"
 
 #include "base/lazy_instance.h"
 #include "chrome/browser/guestview/adview/adview_guest.h"
 #include "chrome/browser/guestview/guestview_constants.h"
 #include "chrome/browser/guestview/webview/webview_guest.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/common/content_settings.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/url_constants.h"
 #include "extensions/browser/event_router.h"
 #include "net/base/escape.h"
 
 using content::WebContents;
 
 namespace {
 
@@ skipping 89 matching lines @@
   // Since persistence is optional, the path must either be empty or the
   // literal string.
   *in_memory = (site.path() != "/persist");
   // The partition name is user supplied value, which we have encoded when the
   // URL was created, so it needs to be decoded.
   *partition_name = net::UnescapeURLComponent(site.query(),
                                               net::UnescapeRule::NORMAL);
   return true;
 }
 
+// static
+void GuestView::GetDefaultContentSettingRules(
+    RendererContentSettingRules* rules) {
+  rules->image_rules.clear();
+  rules->image_rules.push_back(ContentSettingPatternSource(
+    ContentSettingsPattern::Wildcard(),
+    ContentSettingsPattern::Wildcard(),
+    CONTENT_SETTING_ALLOW,
+    "default",
+    false));

[jochen (gone - plz use gerrit), 2013/12/03 08:55:21]

please add incongito as parameter instead of creating the rules twice

[Fady Samuel, 2013/12/03 15:31:27]

Done.

+  rules->image_rules.push_back(ContentSettingPatternSource(
+    ContentSettingsPattern::Wildcard(),
+    ContentSettingsPattern::Wildcard(),
+    CONTENT_SETTING_ALLOW,
+    "default",
+    true));
+
+  rules->script_rules.clear();
+  rules->script_rules.push_back(ContentSettingPatternSource(
+    ContentSettingsPattern::Wildcard(),
+    ContentSettingsPattern::Wildcard(),
+    CONTENT_SETTING_ALLOW,
+    std::string(),
+    false));
+  rules->script_rules.push_back(ContentSettingPatternSource(
+    ContentSettingsPattern::Wildcard(),
+    ContentSettingsPattern::Wildcard(),
+    CONTENT_SETTING_ALLOW,
+    std::string(),
+    true));
+}
+
 void GuestView::Attach(content::WebContents* embedder_web_contents,
                        const base::DictionaryValue& args) {
   embedder_web_contents_ = embedder_web_contents;
   embedder_render_process_id_ =
       embedder_web_contents->GetRenderProcessHost()->GetID();
   args.GetInteger(guestview::kParameterInstanceId, &view_instance_id_);
 
   std::pair<int, int> key(embedder_render_process_id_, guest_instance_id_);
   embedder_guestview_map.Get().insert(std::make_pair(key, this));
 
@@ skipping 59 matching lines @@
 void GuestView::SendQueuedEvents() {
   if (!attached())
     return;
 
   while (!pending_events_.empty()) {
     Event* event = pending_events_.front();
     pending_events_.pop();
     DispatchEvent(event);
   }
 }