 Chromium Code Reviews
 Chromium Code Reviews Issue 783003002:
  Introduce media::RendererFactory interface.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 783003002:
  Introduce media::RendererFactory interface.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: media/filters/default_renderer_factory.h | 
| diff --git a/media/filters/default_renderer_factory.h b/media/filters/default_renderer_factory.h | 
| new file mode 100644 | 
| index 0000000000000000000000000000000000000000..7e787e8afdc6462abb4884c757624f135d402ee1 | 
| --- /dev/null | 
| +++ b/media/filters/default_renderer_factory.h | 
| @@ -0,0 +1,65 @@ | 
| +// Copyright 2014 The Chromium Authors. All rights reserved. | 
| +// Use of this source code is governed by a BSD-style license that can be | 
| +// found in the LICENSE file. | 
| + | 
| +#ifndef MEDIA_FILTERS_DEFAULT_RENDERER_FACTORY_H_ | 
| +#define MEDIA_FILTERS_DEFAULT_RENDERER_FACTORY_H_ | 
| + | 
| +#include "base/callback.h" | 
| +#include "base/memory/ref_counted.h" | 
| +#include "base/memory/scoped_ptr.h" | 
| +#include "media/base/media_export.h" | 
| +#include "media/base/renderer_factory.h" | 
| + | 
| +namespace base { | 
| +class SingleThreadTaskRunner; | 
| +} | 
| + | 
| +namespace media { | 
| + | 
| +class AudioHardwareConfig; | 
| +class AudioRendererSink; | 
| +class GpuVideoAcceleratorFactories; | 
| +class MediaLog; | 
| + | 
| +// The default factory class for creating RendererImpl. | 
| +class MEDIA_EXPORT DefaultRendererFactory : public RendererFactory { | 
| + public: | 
| + // Callback for media embedders to create an external Renderer. | 
| + // Note: Ideally we should do this in MediaClient. However, | 
| + // ContentRendererClient::CreateMediaRenderer() requires a RenderFrame. | 
| + // Even though RenderFrame can be obtained with a blink::WebLocalFrame, it | 
| + // seems bad to pollute MediaClient and DefaultRendererFactory with blink | 
| + // types only for this reason. | 
| + typedef base::Callback<scoped_ptr<Renderer>( | 
| + const scoped_refptr<base::SingleThreadTaskRunner>&)> | 
| 
DaleCurtis
2014/12/08 22:12:09
Does this need a parameter? It looks like you coul
 
xhwang
2014/12/08 23:44:09
Done.
 | 
| + ExternalRendererCreationCB; | 
| + | 
| + DefaultRendererFactory( | 
| + const ExternalRendererCreationCB& external_renderer_creation_cb, | 
| + const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner, | 
| + const scoped_refptr<MediaLog>& media_log, | 
| + const scoped_refptr<GpuVideoAcceleratorFactories>& gpu_factories, | 
| + const AudioHardwareConfig& audio_hardware_config); | 
| + ~DefaultRendererFactory() final; | 
| + | 
| + scoped_ptr<Renderer> CreateRenderer( | 
| + AudioRendererSink* audio_renderer_sink) final; | 
| + | 
| + private: | 
| + ExternalRendererCreationCB external_renderer_creation_cb_; | 
| + | 
| + scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_; | 
| + scoped_refptr<MediaLog> media_log_; | 
| + | 
| + // Factories for supporting video accelerators. May be null. | 
| + scoped_refptr<GpuVideoAcceleratorFactories> gpu_factories_; | 
| + | 
| + const AudioHardwareConfig& audio_hardware_config_; | 
| + | 
| + DISALLOW_COPY_AND_ASSIGN(DefaultRendererFactory); | 
| +}; | 
| + | 
| +} // namespace media | 
| + | 
| +#endif // MEDIA_FILTERS_DEFAULT_RENDERER_FACTORY_H_ |