Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: media/filters/default_renderer_factory.cc

Issue 783003002: Introduce media::RendererFactory interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "media/filters/default_renderer_factory.h"
6
7 #include "base/bind.h"
8 #include "base/single_thread_task_runner.h"
9 #include "media/filters/audio_renderer_impl.h"
10 #include "media/filters/ffmpeg_audio_decoder.h"
11 #include "media/filters/ffmpeg_video_decoder.h"
12 #include "media/filters/gpu_video_accelerator_factories.h"
13 #include "media/filters/gpu_video_decoder.h"
14 #include "media/filters/opus_audio_decoder.h"
15 #include "media/filters/renderer_impl.h"
16 #include "media/filters/video_renderer_impl.h"
17 #include "media/filters/vpx_video_decoder.h"
18
19 namespace media {
20
21 // TODO(xhwang): We are abusing CreateMediaSourceErrorEvent() in a lot of places
DaleCurtis 2014/12/08 22:12:09 +1 ... though MSE abuses it to report things that
xhwang 2014/12/08 23:44:09 Acknowledged.
22 // that are not MediaSource related. Fix this in a separate CL.
23 static void LogError(const scoped_refptr<MediaLog>& media_log,
24 const std::string& error) {
25 media_log->AddEvent(media_log->CreateMediaSourceErrorEvent(error));
26 }
27
28 DefaultRendererFactory::DefaultRendererFactory(
29 const ExternalRendererCreationCB& external_renderer_creation_cb,
30 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
31 const scoped_refptr<MediaLog>& media_log,
32 const scoped_refptr<GpuVideoAcceleratorFactories>& gpu_factories,
33 const AudioHardwareConfig& audio_hardware_config)
34 : external_renderer_creation_cb_(external_renderer_creation_cb),
35 media_task_runner_(media_task_runner),
36 media_log_(media_log),
37 gpu_factories_(gpu_factories),
38 audio_hardware_config_(audio_hardware_config) {
39 }
40
41 DefaultRendererFactory::~DefaultRendererFactory() {
42 }
43
44 scoped_ptr<Renderer> DefaultRendererFactory::CreateRenderer(
45 AudioRendererSink* audio_renderer_sink) {
DaleCurtis 2014/12/08 22:12:09 Probably the sink could be created in the RenderFr
xhwang 2014/12/08 23:44:09 Actually I like to pass the AudioRendererSink in s
46 LOG(ERROR) << __FUNCTION__;
DaleCurtis 2014/12/08 22:12:09 DVLOG() ?
xhwang 2014/12/08 23:44:09 oops, debug code that I forgot to remove :) remove
47 DCHECK(audio_renderer_sink);
48
49 if (!external_renderer_creation_cb_.is_null()) {
50 scoped_ptr<Renderer> renderer =
51 external_renderer_creation_cb_.Run(media_task_runner_);
52 if (renderer.get())
53 return renderer.Pass();
54 }
55
56 // Create our audio decoders and renderer.
57 ScopedVector<AudioDecoder> audio_decoders;
58
59 audio_decoders.push_back(new FFmpegAudioDecoder(
60 media_task_runner_, base::Bind(&LogError, media_log_)));
61 audio_decoders.push_back(new OpusAudioDecoder(media_task_runner_));
62
63 scoped_ptr<AudioRenderer> audio_renderer(new AudioRendererImpl(
64 media_task_runner_, audio_renderer_sink, audio_decoders.Pass(),
65 audio_hardware_config_, media_log_));
66
67 // Create our video decoders and renderer.
68 ScopedVector<VideoDecoder> video_decoders;
69
70 // |gpu_factories_| requires that its entry points be called on its
71 // |GetTaskRunner()|. Since |pipeline_| will own decoders created from the
72 // factories, require that their message loops are identical.
73 DCHECK(!gpu_factories_.get() ||
74 (gpu_factories_->GetTaskRunner() == media_task_runner_.get()));
75
76 if (gpu_factories_.get())
77 video_decoders.push_back(new GpuVideoDecoder(gpu_factories_));
78
79 #if !defined(MEDIA_DISABLE_LIBVPX)
80 video_decoders.push_back(new VpxVideoDecoder(media_task_runner_));
81 #endif // !defined(MEDIA_DISABLE_LIBVPX)
82
83 video_decoders.push_back(new FFmpegVideoDecoder(media_task_runner_));
84
85 scoped_ptr<VideoRenderer> video_renderer(new VideoRendererImpl(
86 media_task_runner_, video_decoders.Pass(), true, media_log_));
87
88 // Create renderer.
89 return scoped_ptr<Renderer>(new RendererImpl(
90 media_task_runner_, audio_renderer.Pass(), video_renderer.Pass()));
91 }
92
93 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698