Introduce media::RendererFactory interface.

mojo/services/html_viewer/webmediaplayer_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/services/html_viewer/webmediaplayer_factory.h"
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/path_service.h"
 #include "base/threading/thread.h"
 #include "media/audio/audio_manager.h"
 #include "media/audio/audio_manager_base.h"
 #include "media/audio/audio_output_stream_sink.h"
 #include "media/base/audio_hardware_config.h"
 #include "media/base/media.h"
 #include "media/base/media_log.h"
-#include "media/base/renderer.h"
 #include "media/blink/webmediaplayer_impl.h"
 #include "media/blink/webmediaplayer_params.h"
+#include "media/filters/default_renderer_factory.h"
 #include "media/filters/gpu_video_accelerator_factories.h"
 #include "media/mojo/interfaces/media_renderer.mojom.h"
-#include "media/mojo/services/mojo_renderer_impl.h"
+#include "media/mojo/services/mojo_renderer_factory.h"
 #include "mojo/public/cpp/application/connect.h"
 #include "mojo/public/interfaces/application/shell.mojom.h"
 
 namespace mojo {
 
 WebMediaPlayerFactory::WebMediaPlayerFactory(
     const scoped_refptr<base::SingleThreadTaskRunner>& compositor_task_runner,
     bool enable_mojo_media_renderer)
     : compositor_task_runner_(compositor_task_runner),
       enable_mojo_media_renderer_(enable_mojo_media_renderer),
@@ skipping 13 matching lines @@
 
 WebMediaPlayerFactory::~WebMediaPlayerFactory() {
 }
 
 blink::WebMediaPlayer* WebMediaPlayerFactory::CreateMediaPlayer(
     blink::WebLocalFrame* frame,
     const blink::WebURL& url,
     blink::WebMediaPlayerClient* client,
     Shell* shell) {
 #if defined(OS_ANDROID)
-  return NULL;
+  return nullptr;
 #else
-  scoped_ptr<media::Renderer> renderer;
+  scoped_refptr<media::MediaLog> media_log(new media::MediaLog());
+  scoped_ptr<media::RendererFactory> media_renderer_factory;
 
   if (enable_mojo_media_renderer_) {
     ServiceProviderPtr media_renderer_service_provider;
     shell->ConnectToApplication("mojo:media",
                                 GetProxy(&media_renderer_service_provider));
-
-    MediaRendererPtr mojo_media_renderer;
-    ConnectToService(media_renderer_service_provider.get(),
-                     &mojo_media_renderer);
-
-    renderer.reset(new media::MojoRendererImpl(GetMediaThreadTaskRunner(),
-                                               mojo_media_renderer.Pass()));
+    media_renderer_factory.reset(
+        new media::MojoRendererFactory(media_renderer_service_provider.Pass()));
+  } else {
+    media_renderer_factory.reset(
+        new media::DefaultRendererFactory(media_log,
+                                          nullptr,  // No GPU factory.
+                                          GetAudioHardwareConfig()));
   }
 
   media::WebMediaPlayerParams params(
-      media::WebMediaPlayerParams::DeferLoadCB(),
-      CreateAudioRendererSink(),
-      GetAudioHardwareConfig(),
-      new media::MediaLog(),
-      scoped_refptr<media::GpuVideoAcceleratorFactories>(),
-      GetMediaThreadTaskRunner(),
-      compositor_task_runner_,
-      NULL);
+      media::WebMediaPlayerParams::DeferLoadCB(), CreateAudioRendererSink(),
+      media_log, GetMediaThreadTaskRunner(), compositor_task_runner_, NULL);

[jamesr, 2014/12/09 04:25:00]

nullptr

[xhwang, 2014/12/09 18:05:52]

Done.

   base::WeakPtr<media::WebMediaPlayerDelegate> delegate;
 
   // TODO(xhwang): Provide a media based CdmFactory implementation.
-  return new media::WebMediaPlayerImpl(frame, client, delegate, renderer.Pass(),
-                                       nullptr, params);
+  return new media::WebMediaPlayerImpl(
+      frame, client, delegate, media_renderer_factory.Pass(), nullptr, params);
 #endif
 }
 
 const media::AudioHardwareConfig&
 WebMediaPlayerFactory::GetAudioHardwareConfig() {
   return audio_hardware_config_;
 }
 
 scoped_refptr<media::AudioRendererSink>
 WebMediaPlayerFactory::CreateAudioRendererSink() {
   // TODO(dalecurtis): Replace this with an interface to an actual mojo service;
   // the AudioOutputStreamSink will not work in sandboxed processes.
   return new media::AudioOutputStreamSink();
 }
 
 scoped_refptr<base::SingleThreadTaskRunner>
 WebMediaPlayerFactory::GetMediaThreadTaskRunner() {
   if (!media_thread_.IsRunning())
     media_thread_.Start();
 
   return media_thread_.message_loop_proxy();
 }
 
 }  // namespace mojo