Issue 7830020: Revert 99169 - Delay the metrics policy migration call to make sure ownership has been taken.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7830020: Revert 99169 - Delay the metrics policy migration call to make sure ownership has been taken. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 9 months ago by dyu1

Modified:
3 years, 9 months ago

Reviewers:
pastarmovj

CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb, nkostylev+cc_chromium.org, rharrison

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 99169 - Delay the metrics policy migration call to make sure ownership has been taken. This solved the issue that the UI does not reflect the OOBE screen setting on new machines. There will be now a window of 30secs where this value will still be wrong but this is still better than not migrating correctly at all. BUG=chromium-os:19427, 19942 TEST=Check the metrics reporting on the EULA screen and see if the settings UI is checked too. Review URL: http://codereview.chromium.org/7741045 TBR=pastarmovj@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99242

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -91 lines)			Patch
M	chrome/browser/chromeos/login/existing_user_controller.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/ownership_status_checker.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/ownership_status_checker.cc	View	2 chunks	+5 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/login/signed_settings.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/user_cros_settings_provider.cc	View	6 chunks	+24 lines, -70 lines	0 comments	Download

Trybot results:

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages