Breakdown ClientLoadedTime histograms into buckets based on number of clients. Fix RequestTimeThrot…

content/browser/loader/resource_scheduler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_LOADER_RESOURCE_SCHEDULER_H_
 #define CONTENT_BROWSER_LOADER_RESOURCE_SCHEDULER_H_
 
 #include <map>
 #include <set>
 
@@ skipping 158 matching lines @@
   };
   class Client;
 
   typedef int64 ClientId;
   typedef std::map<ClientId, Client*> ClientMap;
   typedef std::set<ScheduledResourceRequest*> RequestSet;
 
   // Called when a ScheduledResourceRequest is destroyed.
   void RemoveRequest(ScheduledResourceRequest* request);
 
+  // Get the total number of Clients the ResourceScheduler knows about.
+  size_t GetNumClients() const;

[mmenke, 2015/01/06 19:30:03]

optional:  Not sure having a method to do this gets us anything.

[aiolos (Not reviewing), 2015/01/07 22:28:16]

Done.

+
   // These calls may update the ThrottleState of all clients, and have the
   // potential to be re-entrant.
   // Called when a Client newly becomes active loading.
   void IncrementActiveClientsLoading();
   // Called when an active and loading Client either completes loading or
   // becomes inactive.
   void DecrementActiveClientsLoading();
 
   void OnLoadingActiveClientsStateChangedForAllClients();
 
@@ skipping 24 matching lines @@
 
   // Returns the client ID for the given |child_id| and |route_id| combo.
   ClientId MakeClientId(int child_id, int route_id);
 
   // Returns the client for the given |child_id| and |route_id| combo.
   Client* GetClient(int child_id, int route_id);
 
   bool should_coalesce_;
   bool should_throttle_;
   ClientMap client_map_;
+  size_t num_clients_;

[mmenke, 2015/01/06 19:30:03]

Not used any more.

[aiolos (Not reviewing), 2015/01/07 22:28:16]

Done.

   size_t active_clients_loading_;
   size_t coalesced_clients_;
   // This is a repeating timer to initiate requests on COALESCED Clients.
   scoped_ptr<base::Timer> coalescing_timer_;
   RequestSet unowned_requests_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_LOADER_RESOURCE_SCHEDULER_H_