Switch Windows to BoringSSL from NSS.

Switch Windows to BoringSSL from NSS.

This is a reland of https://crrev.com/306659 which was reverted because it
broke Syzygy. The problems have since been resolved in Syzygy so we can reland
this.

This is a much much larger change than the diff suggests. If it breaks
something, please revert first and ask questions later.

TBR=brettw@chromium.org,rsleevi@chromium.org

BUG=338884
Committed: https://crrev.com/50b3fb8dc460461cee676ddf9923c5a1d499f4fc
Cr-Commit-Position: refs/heads/master@{#307152}

[davidben, 2014-12-05 22:43:05]

Yet another go. TBRing again. I think we're waiting on a Syzygy smoke test right
now
(http://build.chromium.org/p/client.syzygy/builders/Syzygy%20Smoke%20Test/buil...
I assume?), but let's get the CL ready.

[chrisha, 2014-12-05 22:49:52]

We've just got the ball rolling on a CL to land our new binaries here:

https://codereview.chromium.org/783783002/

Once that lands you're good to go. Thanks for your patience guys!

On Fri Dec 05 2014 at 5:43:07 PM <davidben@chromium.org> wrote:

> Reviewers: brettw, Ryan Sleevi,
>
> Message:
> Yet another go. TBRing again. I think we're waiting on a Syzygy smoke test
> right
> now
> (http://build.chromium.org/p/client.syzygy/builders/Syzygy%
> 20Smoke%20Test/builds/50
> I assume?), but let's get the CL ready.
>
> Description:
> Switch Windows to BoringSSL from NSS.
>
> This is a reland of https://crrev.com/306659 which was reverted because it
> broke Syzygy. The problems have since been resolved in Syzygy so we can
> reland
> this.
>
> This is a much much larger change than the diff suggests. If it breaks
> something, please revert first and ask questions later.
>
> TBR=brettw@chromium.org,rsleevi@chromium.org
>
> BUG=338884
>
> Please review this at https://codereview.chromium.org/782843002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+6, -5 lines):
>    M build/common.gypi
>    M build/config/crypto.gni
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
> f5a3e8052b795e0274c7357cdd9397f719e2f952..5a8f1b9ab4f7f3d90eeb555ebcabff
> 9b59ed141d
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -213,8 +213,8 @@
>               'enable_hidpi%': 1,
>             }],
>
> -          # Enable the OpenSSL backend on Mac OS.
> -          ['OS=="mac"', {
> +          # Enable the OpenSSL backend on Mac OS and Windows.
> +          ['OS=="mac" or OS=="win"', {
>               'use_openssl%': 1,
>             }],
>
> Index: build/config/crypto.gni
> diff --git a/build/config/crypto.gni b/build/config/crypto.gni
> index
> 20004c3edd5f325ec0e7870b22ed752ac0f0b6e3..ee23569f9b2ad79010db779b81ae39
> 9f3f070ec1
> 100644
> --- a/build/config/crypto.gni
> +++ b/build/config/crypto.gni
> @@ -8,9 +8,10 @@
>   # the global build dependency on it should be removed.
>
>   declare_args() {
> -  # Use OpenSSL instead of NSS. This is used for Android, Mac, and NaCl
> untrusted
> -  # code, and is experimental in other cases (see http://crbug.com/62803
> ).
> -  use_openssl = is_android || is_mac || is_nacl
> +  # Use OpenSSL instead of NSS. This is used for Android, Mac, NaCl
> untrusted
> +  # code, and Windows, and is experimental in other cases (see
> +  # http://crbug.com/62803).
> +  use_openssl = is_android || is_mac || is_nacl || is_win
>   }
>
>   # True when we're using OpenSSL for certificate verification and storage.
> We
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[davidben, 2014-12-05 23:54:58]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-12-05 23:56:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/782843002/1

[commit-bot: I haz the power, 2014-12-06 03:34:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-06 03:35:46]

Patchset 1 (id:??) landed as
https://crrev.com/50b3fb8dc460461cee676ddf9923c5a1d499f4fc
Cr-Commit-Position: refs/heads/master@{#307152}