Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: src/x64/builtins-x64.cc

Issue 78283002: Restore saved caller FP registers on stub failure (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 653 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 664
665 void Builtins::Generate_NotifyStubFailure(MacroAssembler* masm) { 665 void Builtins::Generate_NotifyStubFailure(MacroAssembler* masm) {
666 // Enter an internal frame. 666 // Enter an internal frame.
667 { 667 {
668 FrameScope scope(masm, StackFrame::INTERNAL); 668 FrameScope scope(masm, StackFrame::INTERNAL);
669 669
670 // Preserve registers across notification, this is important for compiled 670 // Preserve registers across notification, this is important for compiled
671 // stubs that tail call the runtime on deopts passing their parameters in 671 // stubs that tail call the runtime on deopts passing their parameters in
672 // registers. 672 // registers.
673 __ Pushad(); 673 __ Pushad();
674 __ CallRuntime(Runtime::kNotifyStubFailure, 0); 674 __ CallRuntime(Runtime::kNotifyStubFailure, 0, kSaveFPRegs);
675 __ Popad(); 675 __ Popad();
676 // Tear down internal frame. 676 // Tear down internal frame.
677 } 677 }
678 678
679 __ pop(MemOperand(rsp, 0)); // Ignore state offset 679 __ pop(MemOperand(rsp, 0)); // Ignore state offset
680 __ ret(0); // Return to IC Miss stub, continuation still on stack. 680 __ ret(0); // Return to IC Miss stub, continuation still on stack.
681 } 681 }
682 682
683 683
684 static void Generate_NotifyDeoptimizedHelper(MacroAssembler* masm, 684 static void Generate_NotifyDeoptimizedHelper(MacroAssembler* masm,
(...skipping 751 matching lines...) Expand 10 before | Expand all | Expand 10 after
1436 __ bind(&ok); 1436 __ bind(&ok);
1437 __ ret(0); 1437 __ ret(0);
1438 } 1438 }
1439 1439
1440 1440
1441 #undef __ 1441 #undef __
1442 1442
1443 } } // namespace v8::internal 1443 } } // namespace v8::internal
1444 1444
1445 #endif // V8_TARGET_ARCH_X64 1445 #endif // V8_TARGET_ARCH_X64
OLDNEW
« src/arguments.cc ('K') | « src/arguments.cc ('k') | src/x64/lithium-codegen-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698