Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Issue 782823002: Remove flag for Remote Assistance on Chrome OS (Closed)

Created:
6 years ago by kelvinp
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove flag for Remote Assistance on Chrome OS This CL enables Remote Assistance on Chrome OS by default. BUG=439582 Committed: https://crrev.com/c5f2753822d3e69fcf186c793b67755242dd5325 Cr-Commit-Position: refs/heads/master@{#307113}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Leave histogram unchanged for data decoding in older versions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -33 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc View 3 chunks +9 lines, -15 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
kelvinp
@kalman, Can you help me to take a look at the following files? native_message_host_chromeos.cc extensions/common/switches.cc ...
6 years ago (2014-12-05 21:36:40 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/782823002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/782823002/diff/1/tools/metrics/histograms/histograms.xml#oldcode49011 tools/metrics/histograms/histograms.xml:49011: - <int value="952558794" label="enable-remote-assistance"/> Keep the entry here, since ...
6 years ago (2014-12-05 21:42:12 UTC) #3
kelvinp
On 2014/12/05 21:42:12, Alexei Svitkine wrote: > https://codereview.chromium.org/782823002/diff/1/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml (left): > > https://codereview.chromium.org/782823002/diff/1/tools/metrics/histograms/histograms.xml#oldcode49011 ...
6 years ago (2014-12-05 22:02:31 UTC) #4
not at google - send to devlin
extensions lgtm
6 years ago (2014-12-05 22:04:59 UTC) #5
Alexei Svitkine (slow)
lgtm
6 years ago (2014-12-05 22:20:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/782823002/20001
6 years ago (2014-12-05 22:21:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-05 23:36:09 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-05 23:36:55 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5f2753822d3e69fcf186c793b67755242dd5325
Cr-Commit-Position: refs/heads/master@{#307113}

Powered by Google App Engine
This is Rietveld 408576698