Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 7828065: chromeos: Add WebUI implementation of form repost dialog. (Closed)

Created:
7 years, 7 months ago by Daniel Erat
Modified:
7 years, 7 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

chromeos: Add WebUI implementation of form repost dialog. Chrome OS was previously using the GTK+ version. TEST=manual: reposted a form and checked that the dialog works BUG=chromium-os:18829 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100221

Patch Set 1 #

Patch Set 2 : make some changes for linux views #

Patch Set 3 : ifdefs for other dialogs #

Patch Set 4 : update chrome_browser.gypi #

Patch Set 5 : don't crash on empty response #

Total comments: 17

Patch Set 6 : apply review feedback #

Total comments: 1

Patch Set 7 : whoops, remove extra logging #

Patch Set 8 : merge #

Patch Set 9 : merge. again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -35 lines) Patch
M chrome/browser/browser_resources.grd View 2 chunks +9 lines, -8 lines 0 comments Download
A chrome/browser/resources/dialog.css View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/http_auth.html View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
A chrome/browser/resources/repost_form_warning.html View 1 2 3 4 5 1 chunk +72 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/dialog_stubs_gtk.cc View 1 2 3 4 5 4 chunks +14 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_factory.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/collected_cookies_ui_delegate.cc View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/repost_form_warning_ui.h View 1 2 3 4 5 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/repost_form_warning_ui.cc View 1 2 3 4 5 6 1 chunk +160 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 5 chunks +9 lines, -4 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Daniel Erat
http://codereview.chromium.org/7828065/diff/13/chrome/browser/browser_resources.grd File chrome/browser/browser_resources.grd (right): http://codereview.chromium.org/7828065/diff/13/chrome/browser/browser_resources.grd#newcode144 chrome/browser/browser_resources.grd:144: <include name="IDR_REPOST_FORM_WARNING_HTML" file="resources\repost_form_warning.html" flattenhtml="true" type="BINDATA" /> Only alphabetizing apart ...
7 years, 7 months ago (2011-09-06 16:30:58 UTC) #1
arv (Not doing code reviews)
http://codereview.chromium.org/7828065/diff/13/chrome/browser/resources/repost_form_warning.html File chrome/browser/resources/repost_form_warning.html (right): http://codereview.chromium.org/7828065/diff/13/chrome/browser/resources/repost_form_warning.html#newcode5 chrome/browser/resources/repost_form_warning.html:5: <style type="text/css"> Skip the type here. text/css is the ...
7 years, 7 months ago (2011-09-07 20:58:20 UTC) #2
Daniel Erat
Thanks. Another look? http://codereview.chromium.org/7828065/diff/13/chrome/browser/resources/repost_form_warning.html File chrome/browser/resources/repost_form_warning.html (right): http://codereview.chromium.org/7828065/diff/13/chrome/browser/resources/repost_form_warning.html#newcode5 chrome/browser/resources/repost_form_warning.html:5: <style type="text/css"> On 2011/09/07 20:58:20, arv ...
7 years, 7 months ago (2011-09-08 01:46:56 UTC) #3
arv (Not doing code reviews)
LGTM http://codereview.chromium.org/7828065/diff/9001/chrome/browser/ui/webui/repost_form_warning_ui.cc File chrome/browser/ui/webui/repost_form_warning_ui.cc (right): http://codereview.chromium.org/7828065/diff/9001/chrome/browser/ui/webui/repost_form_warning_ui.cc#newcode111 chrome/browser/ui/webui/repost_form_warning_ui.cc:111: LOG(ERROR) << "XXX OnDialogClosed: json_retval=\"" << json_retval << ...
7 years, 7 months ago (2011-09-08 01:56:25 UTC) #4
Daniel Erat
7 years, 7 months ago (2011-09-08 03:30:46 UTC) #5
On Wed, Sep 7, 2011 at 18:56,  <arv@chromium.org> wrote:
> LGTM
>
>
>
http://codereview.chromium.org/7828065/diff/9001/chrome/browser/ui/webui/repo...
> File chrome/browser/ui/webui/repost_form_warning_ui.cc (right):
>
>
http://codereview.chromium.org/7828065/diff/9001/chrome/browser/ui/webui/repo...
> chrome/browser/ui/webui/repost_form_warning_ui.cc:111: LOG(ERROR) <<
> "XXX OnDialogClosed: json_retval=\"" << json_retval << "\"";
> Do you want to remove this before submit?

Yikes, sorry; will do.  I usually do a final manual pass before asking
for a review but I was in a rush tonight. :-(

> http://codereview.chromium.org/7828065/
>

Powered by Google App Engine
This is Rietveld 408576698