Issue 7828025: Handle the ViewHostMsg_FindReply message which is sent by content(renderer) via the TabContentsDe...

Issue 7828025: Handle the ViewHostMsg_FindReply message which is sent by content(renderer) via the TabContentsDe... (Closed)

Created:
9 years, 3 months ago by ananta

Modified:
9 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Avi (use Gerrit), jam, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Handle the ViewHostMsg_FindReply message which is sent by content(renderer) via the TabContentsDelegate. The other change is to remove an unused Browser member from the ExternalTabContainer class. BUG=87335 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99275

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -35 lines)			Patch
M	chrome/browser/external_tab_container_win.h	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/external_tab_container_win.cc	View	1	2 chunks	+10 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 2	5 chunks	+34 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/find_bar/find_tab_helper.h	View	1	1 chunk	+5 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/find_bar/find_tab_helper.cc	View	1	1 chunk	+5 lines, -14 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_delegate.h	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_delegate.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm http://codereview.chromium.org/7828025/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/7828025/diff/1/chrome/browser/ui/browser.cc#newcode3799 chrome/browser/ui/browser.cc:3799: Browser::FindReplyHelper(tab, request_id, number_of_matches, selection_rect, nit: the Browser:: is ...

9 years, 3 months ago (2011-09-02 00:05:26 UTC) #2

ananta

9 years, 3 months ago (2011-09-02 00:28:28 UTC) #3

http://codereview.chromium.org/7828025/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/7828025/diff/1/chrome/browser/ui/browser.cc#ne...
chrome/browser/ui/browser.cc:3799: Browser::FindReplyHelper(tab, request_id,
number_of_matches, selection_rect,
On 2011/09/02 00:05:26, John Abd-El-Malek wrote:
> nit: the Browser:: is redundant
Done. I also removed the Browser prefix from other TabContentsDelegate overrides
which call out to similar helpers.

Expand Messages | Collapse Messages