Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: Source/bindings/core/v8/custom/V8ElementCustom.cpp

Issue 782793002: Update Element API for CSSOM smooth scrolling to match the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/webexposed/global-interface-listing-expected.txt ('k') | Source/core/dom/Element.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8ElementCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8ElementCustom.cpp b/Source/bindings/core/v8/custom/V8ElementCustom.cpp
index 03744453e4096f4cdadc245a48e5a8501cdf0f2a..1539043cf0333d9dbb830b7907756cc055a84f28 100644
--- a/Source/bindings/core/v8/custom/V8ElementCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8ElementCustom.cpp
@@ -45,38 +45,6 @@
namespace blink {
-void V8Element::scrollLeftAttributeSetterCustom(v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
-{
- ExceptionState exceptionState(ExceptionState::SetterContext, "scrollLeft", "Element", info.Holder(), info.GetIsolate());
- Element* impl = V8Element::toImpl(info.Holder());
-
- if (RuntimeEnabledFeatures::cssomSmoothScrollEnabled() && value->IsObject()) {
- TONATIVE_VOID(Dictionary, scrollOptionsHorizontal, Dictionary(value, info.GetIsolate(), exceptionState));
- impl->setScrollLeft(scrollOptionsHorizontal, exceptionState);
- exceptionState.throwIfNeeded();
- return;
- }
-
- TONATIVE_VOID_EXCEPTIONSTATE(float, position, toFloat(value, exceptionState), exceptionState);
- impl->setScrollLeft(position);
-}
-
-void V8Element::scrollTopAttributeSetterCustom(v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
-{
- ExceptionState exceptionState(ExceptionState::SetterContext, "scrollTop", "Element", info.Holder(), info.GetIsolate());
- Element* impl = V8Element::toImpl(info.Holder());
-
- if (RuntimeEnabledFeatures::cssomSmoothScrollEnabled() && value->IsObject()) {
- TONATIVE_VOID(Dictionary, scrollOptionsVertical, Dictionary(value, info.GetIsolate(), exceptionState));
- impl->setScrollTop(scrollOptionsVertical, exceptionState);
- exceptionState.throwIfNeeded();
- return;
- }
-
- TONATIVE_VOID_EXCEPTIONSTATE(float, position, toFloat(value, exceptionState), exceptionState);
- impl->setScrollTop(position);
-}
-
////////////////////////////////////////////////////////////////////////////////
// Overload resolution for animate()
// FIXME: needs support for union types http://crbug.com/240176
« no previous file with comments | « LayoutTests/webexposed/global-interface-listing-expected.txt ('k') | Source/core/dom/Element.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698