LayoutTests/fast/scroll-behavior/overflow-hidden-scroll-expected.txt - Issue 782793002: Update Element API for CSSOM smooth scrolling to match the spec

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/scroll-behavior/overflow-hidden-scroll-expected.txt

Issue 782793002: Update Element API for CSSOM smooth scrolling to match the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/scroll-behavior/listbox-scrollTop.html ('K') | « LayoutTests/fast/scroll-behavior/overflow-hidden-scroll.html ('k') | LayoutTests/fast/scroll-behavior/overflow-hidden-scrollBy.html » ('j') | Source/core/dom/Element.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 Test that calling scroll on an overflow:hidden element works with both scroll be haviors

	2

	3 This is a testharness.js-based test.

	4 PASS Scroll x:1, y:2, smooth:false

	5 PASS Scroll x:2, y:3, smooth:false

	6 PASS Scroll x:3, y:4, smooth:false

	7 PASS Scroll x:4, y:5, smooth:false

	8 PASS Scroll x:3, y:undefined, smooth:false

	9 PASS Scroll x:undefined, y:4, smooth:false

	10 PASS Scroll x:undefined, y:undefined, smooth:false

	11 FAIL Scroll x:10, y:15, smooth:true assert_equals: expected "3, 4" but got "10, 15"
	Ian Vollick 2014/12/08 16:35:23 Can you please remind me why you're adding these F Can you please remind me why you're adding these FAIL lines to the expected.txt files? I assume that it's because the implementation isn't complete, so even a virtual test suite or adding an InternalSetting to enable smooth scrolling wouldn't get these tests passing? ajuma 2014/12/08 18:34:13 Yes, these are here only because the implementatio Show quoted text On 2014/12/08 16:35:23, vollick wrote: > Can you please remind me why you're adding these FAIL lines to the expected.txt > files? I assume that it's because the implementation isn't complete, so even a > virtual test suite or adding an InternalSetting to enable smooth scrolling > wouldn't get these tests passing? Yes, these are here only because the implementation isn't complete.
	12 FAIL Scroll x:20, y:25, smooth:true assert_equals: expected "10, 15" but got "20 , 25"

	13 FAIL Scroll x:30, y:35, smooth:true assert_equals: expected "20, 25" but got "30 , 35"

	14 FAIL Scroll x:40, y:45, smooth:true assert_equals: expected "30, 35" but got "40 , 45"

	15 FAIL Scroll x:45, y:undefined, smooth:true assert_equals: expected "40, 45" but got "45, 45"

	16 FAIL Scroll x:undefined, y:40, smooth:true assert_equals: expected "45, 45" but got "45, 40"

	17 FAIL Scroll x:4000, y:4100, smooth:true assert_equals: expected "45, 40" but got "4000, 4100"

	18 FAIL Scroll x:15, y:20, smooth:true assert_equals: expected "4000, 4100" but got "15, 20"

	19 FAIL Scroll x:4100, y:4000, smooth:true assert_equals: expected "15, 20" but got "4100, 4000"

	20 FAIL Scroll x:10, y:5, smooth:true assert_equals: expected "4100, 4000" but got "10, 5"

	21 Harness: the test ran to completion.

	22

OLD	NEW