Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 782723002: Refactor part of CompositorImpl::SetVisible() into its own method. (Closed)

Created:
6 years ago by auygun
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactor part of CompositorImpl::SetVisible() into its own method. Add method CompositorImpl::CreateLayerTreeHost() and move part of CompositorImpl::SetVisible() that creates LayerTreeHost into it. BUG= Committed: https://crrev.com/b2101b61fd870b4b8f8a8a1421b355cda635649f Cr-Commit-Position: refs/heads/master@{#307221}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -34 lines) Patch
M content/browser/renderer_host/compositor_impl_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 chunks +39 lines, -34 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
auygun
On 2014/12/05 14:38:14, auygun wrote: > mailto:auygun@opera.com changed reviewers: > + mailto:aelias@chromium.org, mailto:sievers@chromium.org @reviewer: Does ...
6 years ago (2014-12-05 14:41:03 UTC) #2
auygun
On 2014/12/05 14:41:03, auygun wrote: > On 2014/12/05 14:38:14, auygun wrote: > > mailto:auygun@opera.com changed ...
6 years ago (2014-12-05 14:50:01 UTC) #3
auygun
6 years ago (2014-12-05 14:50:13 UTC) #4
aelias_OOO_until_Jul13
lgtm https://codereview.chromium.org/782723002/diff/1/content/browser/renderer_host/compositor_impl_android.cc File content/browser/renderer_host/compositor_impl_android.cc (right): https://codereview.chromium.org/782723002/diff/1/content/browser/renderer_host/compositor_impl_android.cc#newcode392 content/browser/renderer_host/compositor_impl_android.cc:392: void CompositorImpl::CreateLayerTreeHost() { Please add "DCHECK(!host_);" at the ...
6 years ago (2014-12-05 19:38:00 UTC) #5
auygun
On 2014/12/05 19:38:00, aelias wrote: > lgtm > > https://codereview.chromium.org/782723002/diff/1/content/browser/renderer_host/compositor_impl_android.cc > File content/browser/renderer_host/compositor_impl_android.cc (right): > ...
6 years ago (2014-12-08 09:18:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/782723002/20001
6 years ago (2014-12-08 09:19:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-08 10:46:31 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-08 10:48:08 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b2101b61fd870b4b8f8a8a1421b355cda635649f
Cr-Commit-Position: refs/heads/master@{#307221}

Powered by Google App Engine
This is Rietveld 408576698