chrome/browser/extensions/bookmark_app_helper_unittest.cc - Issue 782693002: Ensure there are always nice icons for bookmark apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/bookmark_app_helper_unittest.cc

Issue 782693002: Ensure there are always nice icons for bookmark apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review; test Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/bookmark_app_helper.cc ('K') | « chrome/browser/extensions/bookmark_app_helper.cc ('k') | chrome/browser/extensions/convert_web_app.cc » ('j') | chrome/common/extensions/manifest_handlers/app_icon_color_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/bookmark_app_helper_unittest.cc

diff --git a/chrome/browser/extensions/bookmark_app_helper_unittest.cc b/chrome/browser/extensions/bookmark_app_helper_unittest.cc

index 7afd55a5370da4ff4ca93e17341173e77c62b6ca..42c5c5d09d4d9f37370db7115cae334a87e6ba85 100644

--- a/chrome/browser/extensions/bookmark_app_helper_unittest.cc

+++ b/chrome/browser/extensions/bookmark_app_helper_unittest.cc

@@ -234,7 +234,8 @@ TEST_F(BookmarkAppHelperExtensionServiceTest, CreateBookmarkAppNoContents) {

EXPECT_EQ(kAppTitle, extension->name());

EXPECT_EQ(kAppDescription, extension->description());

EXPECT_EQ(GURL(kAppUrl), AppLaunchInfo::GetLaunchWebURL(extension));

- EXPECT_FALSE(

+ // The tiny icon should have been removed and only the generated ones used.

+ EXPECT_TRUE(

IconsInfo::GetIconResource(

extension, kIconSizeTiny, ExtensionIconSet::MATCH_EXACTLY).empty());

EXPECT_FALSE(