extensions/common/manifest_constants.cc - Issue 782693002: Ensure there are always nice icons for bookmark apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_constants.cc

Issue 782693002: Ensure there are always nice icons for bookmark apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac compile Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/manifest_constants.cc

diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc

index a7c287a46f98026e45101c823811d5d5a0eb8373..e8099df4b0813c92070c3332b119369023a67121 100644

--- a/extensions/common/manifest_constants.cc

+++ b/extensions/common/manifest_constants.cc

@@ -12,6 +12,7 @@ const char kAboutPage[] = "about_page";

const char kAllFrames[] = "all_frames";

const char kAltKey[] = "altKey";

const char kApp[] = "app";

+const char kAppIconColor[] = "app.icon_color";

const char kAutomation[] = "automation";

const char kBackgroundAllowJsAccess[] = "background.allow_js_access";

const char kBackgroundPage[] = "background.page";

@@ -279,6 +280,7 @@ const char kInvalidAboutPageExpectRelativePath[] =

"Invalid value for 'about_page'. Value must be a relative path.";

const char kInvalidAllFrames[] =

"Invalid value for 'content_scripts[*].all_frames'.";

+const char kInvalidAppIconColor[] = "Invalid value for app.icon_color.";

const char kInvalidBackground[] =

"Invalid value for 'background_page'.";

const char kInvalidBackgroundAllowJsAccess[] =

« no previous file with comments | « extensions/common/manifest_constants.h ('k') | extensions/extensions.gyp » ('j') | no next file with comments »