chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc - Issue 782693002: Ensure there are always nice icons for bookmark apps.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

Issue 782693002: Ensure there are always nice icons for bookmark apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/extension_sync_service.cc ('k') | chrome/chrome_common.gypi » ('j') | chrome/common/extensions/manifest_handlers/app_icon_color_info.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h"	5 #include "chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h"

6	6

7 #include "base/strings/string16.h"	7 #include "base/strings/string16.h"

8 #include "base/strings/utf_string_conversions.h"	8 #include "base/strings/utf_string_conversions.h"

9 #include "chrome/browser/extensions/app_icon_loader_impl.h"	9 #include "chrome/browser/extensions/app_icon_loader_impl.h"

10 #include "chrome/browser/extensions/bookmark_app_helper.h"	10 #include "chrome/browser/extensions/bookmark_app_helper.h"

(...skipping 255 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
266 extensions::ExtensionRegistry::Get(profile_)->GetExtensionById(	266 extensions::ExtensionRegistry::Get(profile_)->GetExtensionById(

267 extension_id_, extensions::ExtensionRegistry::EVERYTHING);	267 extension_id_, extensions::ExtensionRegistry::EVERYTHING);

268 if (extension && base::UTF8ToUTF16(extension->name()) == title_tf_->text())	268 if (extension && base::UTF8ToUTF16(extension->name()) == title_tf_->text())

269 return;	269 return;

270	270

271 // Reinstall the app with an updated name.	271 // Reinstall the app with an updated name.

272 WebApplicationInfo install_info(web_app_info_);	272 WebApplicationInfo install_info(web_app_info_);

273 install_info.title = title_tf_->text();	273 install_info.title = title_tf_->text();

274	274

275 extensions::CreateOrUpdateBookmarkApp(GetExtensionService(profile_),	275 extensions::CreateOrUpdateBookmarkApp(GetExtensionService(profile_),

276 install_info);	276 &install_info);

277 }	277 }

OLD	NEW