extensions/DEPS - Issue 782693002: Ensure there are always nice icons for bookmark apps.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/DEPS

Issue 782693002: Ensure there are always nice icons for bookmark apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac compile Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # Do not add Chrome dependencies. Much work went into removing them.	2 # Do not add Chrome dependencies. Much work went into removing them.

3 "+components/crx_file",	3 "+components/crx_file",

4 "+components/url_matcher",	4 "+components/url_matcher",

5 "-content",	5 "-content",

6 "+content/grit/content_resources.h",	6 "+content/grit/content_resources.h",

7 "+content/public/common",	7 "+content/public/common",

8 "+content/public/test",	8 "+content/public/test",

9 "+crypto",	9 "+crypto",

10 "-extensions/components",	10 "-extensions/components",

11 "+extensions/test",	11 "+extensions/test",

12 "+grit/extensions_renderer_resources.h",	12 "+grit/extensions_renderer_resources.h",

13 "+grit/extensions_resources.h",	13 "+grit/extensions_resources.h",

14 "+mojo/public",	14 "+mojo/public",

	15 "+third_party/skia/include",

15 "+testing",	16 "+testing",

16	17

17 # Minimal UI dependencies. There are two good rules for UI dependencies here:	18 # Minimal UI dependencies. There are two good rules for UI dependencies here:

18 #	19 #

19 # 1) UI components should only be added as they are needed, and	20 # 1) UI components should only be added as they are needed, and

20 # 2) if //content doesn't allow it, //extensions probably won't allow it.	21 # 2) if //content doesn't allow it, //extensions probably won't allow it.

21 # (see for example ui/views)	22 # (see for example ui/views)

22 "-ui",	23 "-ui",

23 "+ui/base",	24 "+ui/base",

24 "+ui/gfx",	25 "+ui/gfx",

(...skipping 19 matching lines...) Expand all Loading...
44 "+chrome/browser/extensions/extension_test_message_listener.h",	45 "+chrome/browser/extensions/extension_test_message_listener.h",

45 "+chrome/browser/extensions/test_extension_dir.h",	46 "+chrome/browser/extensions/test_extension_dir.h",

46 "+chrome/browser/extensions/test_extension_prefs.h",	47 "+chrome/browser/extensions/test_extension_prefs.h",

47 "+chrome/browser/extensions/test_extension_system.h",	48 "+chrome/browser/extensions/test_extension_system.h",

48 "+chrome/browser/ui/browser.h",	49 "+chrome/browser/ui/browser.h",

49 "+chrome/common/extensions/features/feature_channel.h",	50 "+chrome/common/extensions/features/feature_channel.h",

50 "+chrome/test/base/testing_profile.h",	51 "+chrome/test/base/testing_profile.h",

51 "+chrome/test/base/ui_test_utils.h",	52 "+chrome/test/base/ui_test_utils.h",

52 ],	53 ],

53 }	54 }

OLD	NEW

« no previous file with comments | « extensions/BUILD.gn ('k') | extensions/browser/BUILD.gn » ('j') | no next file with comments »