Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/browser/extensions/bookmark_app_helper.h

Issue 782693002: Ensure there are always nice icons for bookmark apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac compile Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_BOOKMARK_APP_HELPER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_BOOKMARK_APP_HELPER_H_
6 #define CHROME_BROWSER_EXTENSIONS_BOOKMARK_APP_HELPER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_BOOKMARK_APP_HELPER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <vector> 10 #include <vector>
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 100
101 // Used to install the created bookmark app. 101 // Used to install the created bookmark app.
102 scoped_refptr<extensions::CrxInstaller> crx_installer_; 102 scoped_refptr<extensions::CrxInstaller> crx_installer_;
103 103
104 content::NotificationRegistrar registrar_; 104 content::NotificationRegistrar registrar_;
105 }; 105 };
106 106
107 // Creates or updates a bookmark app from the given |web_app_info|. Icons will 107 // Creates or updates a bookmark app from the given |web_app_info|. Icons will
108 // not be downloaded so only supplied icon data will be used. 108 // not be downloaded so only supplied icon data will be used.
109 void CreateOrUpdateBookmarkApp(ExtensionService* service, 109 void CreateOrUpdateBookmarkApp(ExtensionService* service,
110 WebApplicationInfo& web_app_info); 110 WebApplicationInfo* web_app_info);
111 111
112 // Retrieves the WebApplicationInfo that represents a given bookmark app. 112 // Retrieves the WebApplicationInfo that represents a given bookmark app.
113 // |callback| will be called with a WebApplicationInfo which is populated with 113 // |callback| will be called with a WebApplicationInfo which is populated with
114 // the extension's details and icons on success and an unpopulated 114 // the extension's details and icons on success and an unpopulated
115 // WebApplicationInfo on failure. 115 // WebApplicationInfo on failure.
116 void GetWebApplicationInfoFromApp( 116 void GetWebApplicationInfoFromApp(
117 content::BrowserContext* browser_context, 117 content::BrowserContext* browser_context,
118 const extensions::Extension* extension, 118 const extensions::Extension* extension,
119 const base::Callback<void(const WebApplicationInfo&)> callback); 119 const base::Callback<void(const WebApplicationInfo&)> callback);
120 120
121 // Returns whether the given |url| is a valid bookmark app url. 121 // Returns whether the given |url| is a valid bookmark app url.
122 bool IsValidBookmarkAppUrl(const GURL& url); 122 bool IsValidBookmarkAppUrl(const GURL& url);
123 123
124 } // namespace extensions 124 } // namespace extensions
125 125
126 #endif // CHROME_BROWSER_EXTENSIONS_BOOKMARK_APP_HELPER_H_ 126 #endif // CHROME_BROWSER_EXTENSIONS_BOOKMARK_APP_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/app_sync_data.cc ('k') | chrome/browser/extensions/bookmark_app_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698