Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 782643002: Fix upload_to_google_storage.py. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
Reviewers:
Vadim Sh., iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, Dirk Pranke, iannucci+depot_tools_chromium.org
Project:
tools
Visibility:
Public.

Description

Fix upload_to_google_storage.py. r293250 broke it. I didn't realize that check_bucket_permissions was shared code. It now only returns a single value. TBR=vadimsh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293256

Patch Set 1 #

Patch Set 2 : merge to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M upload_to_google_storage.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
ojan
deeepoooot_toooools Sorry for all the breakage and TBR. :(
6 years ago (2014-12-05 00:02:20 UTC) #2
ojan
6 years ago (2014-12-05 00:03:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 293256.

Powered by Google App Engine
This is Rietveld 408576698