views/controls/textfield/native_textfield_views.cc - Issue 7826039: Identify the omnibox as a URL field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/controls/textfield/native_textfield_views.cc

Issue 7826039: Identify the omnibox as a URL field. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: views/controls/textfield/native_textfield_views.cc

diff --git a/views/controls/textfield/native_textfield_views.cc b/views/controls/textfield/native_textfield_views.cc

index 47ff3029bb754c2d69777a3fce748911e5744f9f..9fad4c450cd73bb86e0cafaf24fdd66aeee377e7 100644

--- a/views/controls/textfield/native_textfield_views.cc

+++ b/views/controls/textfield/native_textfield_views.cc

@@ -700,11 +700,7 @@ void NativeTextfieldViews::InsertChar(char16 ch, int flags) {

}

ui::TextInputType NativeTextfieldViews::GetTextInputType() {

- if (textfield_->read_only() || !textfield_->IsEnabled())

- return ui::TEXT_INPUT_TYPE_NONE;

- else if (textfield_->IsPassword())

- return ui::TEXT_INPUT_TYPE_PASSWORD;

- return ui::TEXT_INPUT_TYPE_TEXT;

+ return textfield_->GetTextInputType();

}

gfx::Rect NativeTextfieldViews::GetCaretBounds() {