Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: Source/modules/webaudio/AudioSummingJunction.cpp

Issue 782603004: Web Audio: Oilpan: Trace AudioSummingJunction::m_renderingOutputs (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add a FIXME Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/AudioSummingJunction.cpp
diff --git a/Source/modules/webaudio/AudioSummingJunction.cpp b/Source/modules/webaudio/AudioSummingJunction.cpp
index 551b90f8b3342c27894b52338385771aac6e0f6d..76a24a302c90178160d158155d008397561c4a11 100644
--- a/Source/modules/webaudio/AudioSummingJunction.cpp
+++ b/Source/modules/webaudio/AudioSummingJunction.cpp
@@ -56,6 +56,11 @@ AudioSummingJunction::~AudioSummingJunction()
void AudioSummingJunction::trace(Visitor* visitor)
{
visitor->trace(m_context);
+ // FIXME: Oilpan: m_renderingOutputs should not be strong references. This
+ // is a short-term workaround to avoid crashes, and causes AudioNode leaks.
+ AudioContext::AutoLocker locker(m_context);
+ for (size_t i = 0; i < m_renderingOutputs.size(); ++i)
+ visitor->trace(m_renderingOutputs[i]);
}
void AudioSummingJunction::changedOutputs()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698