Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gyp/v8.gyp

Issue 782573002: Sketch of on demand snapshot generation for d8 Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add bits needed by the Chrome implementation Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/snapshot-common.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index 89bfc43667ffaff6d7efb7c33beff5da770b1711..35401cbb813e3fb861de59d8581b7a47aa74192a 100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -166,33 +166,33 @@
'<(INTERMEDIATE_DIR)/snapshot.cc',
'../../src/snapshot-common.cc',
],
- 'actions': [
- {
- 'action_name': 'run_mksnapshot',
- 'inputs': [
- '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mksnapshot<(EXECUTABLE_SUFFIX)',
- ],
- 'outputs': [
- '<(INTERMEDIATE_DIR)/snapshot.cc',
- ],
- 'variables': {
- 'mksnapshot_flags': [
- '--log-snapshot-positions',
- '--logfile', '<(INTERMEDIATE_DIR)/snapshot.log',
- ],
- 'conditions': [
- ['v8_random_seed!=0', {
- 'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'],
- }],
- ],
- },
- 'action': [
- '<@(_inputs)',
- '<@(mksnapshot_flags)',
- '<@(INTERMEDIATE_DIR)/snapshot.cc'
- ],
- },
- ],
+ #'actions': [
+ # {
+ # 'action_name': 'run_mksnapshot',
+ # 'inputs': [
+ # '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mksnapshot<(EXECUTABLE_SUFFIX)',
+ # ],
+ # 'outputs': [
+ # '<(INTERMEDIATE_DIR)/snapshot.cc',
+ # ],
+ # 'variables': {
+ # 'mksnapshot_flags': [
+ # '--log-snapshot-positions',
+ # '--logfile', '<(INTERMEDIATE_DIR)/snapshot.log',
+ # ],
+ # 'conditions': [
+ # ['v8_random_seed!=0', {
+ # 'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'],
+ # }],
+ # ],
+ # },
+ # 'action': [
+ # '<@(_inputs)',
+ # '<@(mksnapshot_flags)',
+ # '<@(INTERMEDIATE_DIR)/snapshot.cc'
+ # ],
+ # },
+ #],
},
{
'target_name': 'v8_nosnapshot',
@@ -259,7 +259,7 @@
}],
],
'dependencies': [
- 'v8_base',
+ 'v8_base', 'v8_libplatform',
],
'include_dirs+': [
'../..',
@@ -268,65 +268,65 @@
'../../src/natives-external.cc',
'../../src/snapshot-external.cc',
],
- 'actions': [
- {
- 'action_name': 'run_mksnapshot (external)',
- 'inputs': [
- '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mksnapshot<(EXECUTABLE_SUFFIX)',
- ],
- 'variables': {
- 'mksnapshot_flags': [
- '--log-snapshot-positions',
- '--logfile', '<(INTERMEDIATE_DIR)/snapshot.log',
- ],
- 'conditions': [
- ['v8_random_seed!=0', {
- 'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'],
- }],
- ],
- },
- 'conditions': [
- ['want_separate_host_toolset==1', {
- 'target_conditions': [
- ['_toolset=="host"', {
- 'outputs': [
- '<(INTERMEDIATE_DIR)/snapshot.cc',
- '<(PRODUCT_DIR)/snapshot_blob_host.bin',
- ],
- 'action': [
- '<@(_inputs)',
- '<@(mksnapshot_flags)',
- '<@(INTERMEDIATE_DIR)/snapshot.cc',
- '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_host.bin',
- ],
- }, {
- 'outputs': [
- '<(INTERMEDIATE_DIR)/snapshot.cc',
- '<(PRODUCT_DIR)/snapshot_blob.bin',
- ],
- 'action': [
- '<@(_inputs)',
- '<@(mksnapshot_flags)',
- '<@(INTERMEDIATE_DIR)/snapshot.cc',
- '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob.bin',
- ],
- }],
- ],
- }, {
- 'outputs': [
- '<(INTERMEDIATE_DIR)/snapshot.cc',
- '<(PRODUCT_DIR)/snapshot_blob.bin',
- ],
- 'action': [
- '<@(_inputs)',
- '<@(mksnapshot_flags)',
- '<@(INTERMEDIATE_DIR)/snapshot.cc',
- '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob.bin',
- ],
- }],
- ],
- },
- ],
+ #'actions': [
+ # {
+ # 'action_name': 'run_mksnapshot (external)',
+ # 'inputs': [
+ # '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mksnapshot<(EXECUTABLE_SUFFIX)',
+ # ],
+ # 'variables': {
+ # 'mksnapshot_flags': [
+ # '--log-snapshot-positions',
+ # '--logfile', '<(INTERMEDIATE_DIR)/snapshot.log',
+ # ],
+ # 'conditions': [
+ # ['v8_random_seed!=0', {
+ # 'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'],
+ # }],
+ # ],
+ # },
+ # 'conditions': [
+ # ['want_separate_host_toolset==1', {
+ # 'target_conditions': [
+ # ['_toolset=="host"', {
+ # 'outputs': [
+ # '<(INTERMEDIATE_DIR)/snapshot.cc',
+ # '<(PRODUCT_DIR)/snapshot_blob_host.bin',
+ # ],
+ # 'action': [
+ # '<@(_inputs)',
+ # '<@(mksnapshot_flags)',
+ # '<@(INTERMEDIATE_DIR)/snapshot.cc',
+ # '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_host.bin',
+ # ],
+ # }, {
+ # 'outputs': [
+ # '<(INTERMEDIATE_DIR)/snapshot.cc',
+ # '<(PRODUCT_DIR)/snapshot_blob.bin',
+ # ],
+ # 'action': [
+ # '<@(_inputs)',
+ # '<@(mksnapshot_flags)',
+ # '<@(INTERMEDIATE_DIR)/snapshot.cc',
+ # '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob.bin',
+ # ],
+ # }],
+ # ],
+ # }, {
+ # 'outputs': [
+ # '<(INTERMEDIATE_DIR)/snapshot.cc',
+ # '<(PRODUCT_DIR)/snapshot_blob.bin',
+ # ],
+ # 'action': [
+ # '<@(_inputs)',
+ # '<@(mksnapshot_flags)',
+ # '<@(INTERMEDIATE_DIR)/snapshot.cc',
+ # '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob.bin',
+ # ],
+ # }],
+ # ],
+ # },
+ #],
}],
],
},
« no previous file with comments | « src/snapshot-common.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698