Support disconnecting from wireless networks.

Support disconnecting from wireless networks.

NOTE: Depending if this or 720453002 lands first an event should also fire when a network disconnects.

BUG=387869
Committed: https://crrev.com/ea7bdf5268e4d2be507aea24f985bd6a3f3421f5
Cr-Commit-Position: refs/heads/master@{#307286}

[zentaro, 2014-12-05 16:56:32]

zentaro@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2014-12-05 20:39:43]

https://codereview.chromium.org/782493003/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/networking_private/networking_private_linux.cc
(right):

https://codereview.chromium.org/782493003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_private/networking_private_linux.cc:119:
// fails.
Since this is identical to OnNetworkConnected, maybe just rename that
OnNetworkConnectOperationCompleted?

https://codereview.chromium.org/782493003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_private/networking_private_linux.cc:369:
dbus::ObjectPath device_path(device_path_str);
This is only used once below (the other time should just be device_path_str).
Just use dbus::ObjectPath(device_path_str) where you need it.

https://codereview.chromium.org/782493003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_private/networking_private_linux.cc:372:
GetAllWiFiAccessPoints(/* configured_only */ false, /* visible_only */ false,
switch order: (false /* configured_only */, ...)

https://codereview.chromium.org/782493003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_private/networking_private_linux.cc:385:
if (connection_state != ::onc::connection_state::kNotConnected) {
Invert + early exit

[zentaro, 2014-12-05 21:39:33]

https://codereview.chromium.org/782493003/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/networking_private/networking_private_linux.cc
(right):

https://codereview.chromium.org/782493003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_private/networking_private_linux.cc:119:
// fails.
On 2014/12/05 20:39:43, stevenjb wrote:
> Since this is identical to OnNetworkConnected, maybe just rename that
> OnNetworkConnectOperationCompleted?

Done.

https://codereview.chromium.org/782493003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_private/networking_private_linux.cc:369:
dbus::ObjectPath device_path(device_path_str);
On 2014/12/05 20:39:43, stevenjb wrote:
> This is only used once below (the other time should just be device_path_str).
> Just use dbus::ObjectPath(device_path_str) where you need it.

It's used in the log statement on 397 too.

https://codereview.chromium.org/782493003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_private/networking_private_linux.cc:372:
GetAllWiFiAccessPoints(/* configured_only */ false, /* visible_only */ false,
On 2014/12/05 20:39:43, stevenjb wrote:
> switch order: (false /* configured_only */, ...)

Done.

https://codereview.chromium.org/782493003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_private/networking_private_linux.cc:385:
if (connection_state != ::onc::connection_state::kNotConnected) {
On 2014/12/05 20:39:43, stevenjb wrote:
> Invert + early exit

Done.

[stevenjb, 2014-12-08 17:37:43]

lgtm w/nit

https://codereview.chromium.org/782493003/diff/40001/chrome/browser/extension...
File
chrome/browser/extensions/api/networking_private/networking_private_linux.cc
(right):

https://codereview.chromium.org/782493003/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/networking_private/networking_private_linux.cc:388:
<< device_path.value();
nit: This is just device_path_str, you really don't need the extra local.

[zentaro, 2014-12-08 17:52:06]

https://codereview.chromium.org/782493003/diff/40001/chrome/browser/extension...
File
chrome/browser/extensions/api/networking_private/networking_private_linux.cc
(right):

https://codereview.chromium.org/782493003/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/networking_private/networking_private_linux.cc:388:
<< device_path.value();
On 2014/12/08 17:37:43, stevenjb wrote:
> nit: This is just device_path_str, you really don't need the extra local.
> 

Done.

[zentaro, 2014-12-08 17:52:13]

The CQ bit was checked by zentaro@chromium.org

[commit-bot: I haz the power, 2014-12-08 17:53:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/782493003/60001

[commit-bot: I haz the power, 2014-12-08 18:37:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-12-08 18:39:29]

Patchset 4 (id:??) landed as
https://crrev.com/ea7bdf5268e4d2be507aea24f985bd6a3f3421f5
Cr-Commit-Position: refs/heads/master@{#307286}