Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 782473002: [turbofan] Redundant load elimination. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Redundant load elimination. This is an initial version of redundant load elimination, currently limited to LoadField operators, and implemented by walking the effect chain. TEST=unittests R=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/b3ace35209fe18693537f5728418be8fb5874bae

Patch Set 1 #

Patch Set 2 : test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/compiler/load-elimination.h View 1 chunk +29 lines, -0 lines 0 comments Download
A src/compiler/load-elimination.cc View 1 1 chunk +76 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A test/unittests/compiler/load-elimination-unittest.cc View 1 1 chunk +72 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Benedikt Meurer
PTAL
6 years ago (2014-12-05 06:51:46 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-05 07:49:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/782473002/20001
6 years ago (2014-12-05 07:50:08 UTC) #5
Benedikt Meurer
6 years ago (2014-12-05 07:59:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b3ace35209fe18693537f5728418be8fb5874bae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698