Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4476)

Unified Diff: chrome/browser/resources/net_internals/log_view_painter.js

Issue 782333002: Certificate Transparency: Adding finch and NetLog logging for EV certs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/net_internals/log_view_painter.js
diff --git a/chrome/browser/resources/net_internals/log_view_painter.js b/chrome/browser/resources/net_internals/log_view_painter.js
index 38b70f816bbc466994c76471dbc5e44c393fc220..2dd0a09656e6cb55f5e289d5eaad5bfc307a9820 100644
--- a/chrome/browser/resources/net_internals/log_view_painter.js
+++ b/chrome/browser/resources/net_internals/log_view_painter.js
@@ -281,6 +281,8 @@ function getParamaterWriterForEventType(eventType) {
case EventType.CERT_VERIFIER_JOB:
case EventType.SSL_CERTIFICATES_RECEIVED:
return writeParamsForCertificates;
+ case EventType.NON_COMPLIANT_EV_CERT_ENCOUNTERED:
+ return writeParamsForNonCompliantCertificate;
case EventType.SSL_VERSION_FALLBACK:
return writeParamsForSSLVersionFallback;
@@ -620,6 +622,26 @@ function writeParamsForCertificates(entry, out, consumedParams) {
}
/**
+ * Outputs the non-compliant certificate parameters of |entry| to |out|.
+ */
+function writeParamsForNonCompliantCertificate(entry, out, consumedParams) {
+ if (typeof(entry.params.non_compliant_cert) == 'object') {
+ if (entry.params.non_compliant_cert.certificates instanceof Array) {
+ var certs = entry.params.non_compliant_cert.certificates.reduce(
+ function(previous, current) {
+ return previous.concat(current.split('\n'));
+ }, new Array());
+ out.writeArrowKey('non_compliant_cert');
+ out.writeSpaceIndentedLines(8, certs);
+ consumedParams.non_compliant_cert = true;
+ }
+ }
+}
+
+
+
+
mmenke 2014/12/09 20:13:32 nit: Should only be one blank line here.
Eran Messeri 2014/12/10 15:38:38 Done.
+/**
* Outputs the SSL version fallback parameters of |entry| to |out|.
*/
function writeParamsForSSLVersionFallback(entry, out, consumedParams) {

Powered by Google App Engine
This is Rietveld 408576698