Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: net/cert/cert_policy_enforcer.h

Issue 782333002: Certificate Transparency: Adding finch and NetLog logging for EV certs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_log_event_type_list.h ('k') | net/cert/cert_policy_enforcer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/cert_policy_enforcer.h
diff --git a/net/cert/cert_policy_enforcer.h b/net/cert/cert_policy_enforcer.h
index e6c7960ac9a28fcc2211e39f2dabdb59974ed3c8..5d6b64b06d6a2d732a947c110c0b01e32d34f696 100644
--- a/net/cert/cert_policy_enforcer.h
+++ b/net/cert/cert_policy_enforcer.h
@@ -7,6 +7,7 @@
#include <stddef.h>
#include "net/base/net_export.h"
+#include "net/base/net_log.h"
namespace net {
@@ -30,21 +31,17 @@ class NET_EXPORT CertPolicyEnforcer {
virtual ~CertPolicyEnforcer();
// Returns true if the collection of SCTs for the given certificate
- // conforms with the CT/EV policy.
+ // conforms with the CT/EV policy. Conformance details are logged to
+ // |net_log|.
// |cert| is the certificate for which the SCTs apply.
// |ct_result| must contain the result of verifying any SCTs associated with
// |cert| prior to invoking this method.
bool DoesConformToCTEVPolicy(X509Certificate* cert,
const ct::EVCertsWhitelist* ev_whitelist,
- const ct::CTVerifyResult& ct_result);
+ const ct::CTVerifyResult& ct_result,
+ const BoundNetLog& net_log);
private:
- bool IsCertificateInWhitelist(X509Certificate* cert,
- const ct::EVCertsWhitelist* ev_whitelist);
-
- bool HasRequiredNumberOfSCTs(X509Certificate* cert,
- const ct::CTVerifyResult& ct_result);
-
bool require_ct_for_ev_;
};
« no previous file with comments | « net/base/net_log_event_type_list.h ('k') | net/cert/cert_policy_enforcer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698