Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chrome/browser/resources/net_internals/log_view_painter.js

Issue 782333002: Certificate Transparency: Adding finch and NetLog logging for EV certs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/packed_ct_ev_whitelist_unittest.cc ('k') | net/base/net_log_event_type_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/net_internals/log_view_painter.js
diff --git a/chrome/browser/resources/net_internals/log_view_painter.js b/chrome/browser/resources/net_internals/log_view_painter.js
index 38b70f816bbc466994c76471dbc5e44c393fc220..7565cd1fa22c14750a3d9db9561d16fdb63c938b 100644
--- a/chrome/browser/resources/net_internals/log_view_painter.js
+++ b/chrome/browser/resources/net_internals/log_view_painter.js
@@ -281,6 +281,8 @@ function getParamaterWriterForEventType(eventType) {
case EventType.CERT_VERIFIER_JOB:
case EventType.SSL_CERTIFICATES_RECEIVED:
return writeParamsForCertificates;
+ case EventType.EV_CERT_CT_COMPLIANCE_CHECKED:
+ return writeParamsForCheckedEVCertificates;
case EventType.SSL_VERSION_FALLBACK:
return writeParamsForSSLVersionFallback;
@@ -585,30 +587,28 @@ function writeParamsForRequestHeaders(entry, out, consumedParams) {
consumedParams.headers = true;
}
+function writeCertificateParam(
+ certs_container, out, consumedParams, paramName) {
+ if (certs_container.certificates instanceof Array) {
+ var certs = certs_container.certificates.reduce(
+ function(previous, current) {
+ return previous.concat(current.split('\n'));
+ }, new Array());
+ out.writeArrowKey(paramName);
+ out.writeSpaceIndentedLines(8, certs);
+ consumedParams[paramName] = true;
+ }
+}
+
/**
* Outputs the certificate parameters of |entry| to |out|.
*/
function writeParamsForCertificates(entry, out, consumedParams) {
- if (entry.params.certificates instanceof Array) {
- var certs = entry.params.certificates.reduce(function(previous, current) {
- return previous.concat(current.split('\n'));
- }, new Array());
- out.writeArrowKey('certificates');
- out.writeSpaceIndentedLines(8, certs);
- consumedParams.certificates = true;
- }
-
- if (typeof(entry.params.verified_cert) == 'object') {
- if (entry.params.verified_cert.certificates instanceof Array) {
- var certs = entry.params.verified_cert.certificates.reduce(
- function(previous, current) {
- return previous.concat(current.split('\n'));
- }, new Array());
- out.writeArrowKey('verified_cert');
- out.writeSpaceIndentedLines(8, certs);
- consumedParams.verified_cert = true;
- }
- }
+ writeCertificateParam(entry.params, out, consumedParams, 'certificates');
+
+ if (typeof(entry.params.verified_cert) == 'object')
+ writeCertificateParam(
+ entry.params.verified_cert, out, consumedParams, 'verified_cert');
if (typeof(entry.params.cert_status) == 'number') {
var valueStr = entry.params.cert_status + ' (' +
@@ -619,6 +619,12 @@ function writeParamsForCertificates(entry, out, consumedParams) {
}
+function writeParamsForCheckedEVCertificates(entry, out, consumedParams) {
+ if (typeof(entry.params.certificate) == 'object')
+ writeCertificateParam(
+ entry.params.certificate, out, consumedParams, 'certificate');
+}
+
/**
* Outputs the SSL version fallback parameters of |entry| to |out|.
*/
« no previous file with comments | « chrome/browser/net/packed_ct_ev_whitelist_unittest.cc ('k') | net/base/net_log_event_type_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698