Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: chrome/browser/net/packed_ct_ev_whitelist.h

Issue 782333002: Certificate Transparency: Adding finch and NetLog logging for EV certs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/net/packed_ct_ev_whitelist.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/packed_ct_ev_whitelist.h
diff --git a/chrome/browser/net/packed_ct_ev_whitelist.h b/chrome/browser/net/packed_ct_ev_whitelist.h
index 6cbc545053861c3f3652acac78dffd3a61308ec3..6520f3ffff7ffe68e0a40298d703dbbece664a21 100644
--- a/chrome/browser/net/packed_ct_ev_whitelist.h
+++ b/chrome/browser/net/packed_ct_ev_whitelist.h
@@ -11,6 +11,7 @@
#include <vector>
#include "base/gtest_prod_util.h"
+#include "base/version.h"
#include "net/cert/ct_ev_whitelist.h"
namespace base {
@@ -30,7 +31,8 @@ class PackedEVCertsWhitelist : public net::ct::EVCertsWhitelist {
public:
// Unpacks the given |compressed_whitelist|. See the class documentation
// for description of the |compressed_whitelist| format.
- explicit PackedEVCertsWhitelist(const std::string& compressed_whitelist);
+ PackedEVCertsWhitelist(const std::string& compressed_whitelist,
+ const base::Version& version);
// Returns true if the |certificate_hash| appears in the EV certificate hashes
// whitelist. Must not be called if IsValid for this instance returned false.
@@ -41,6 +43,9 @@ class PackedEVCertsWhitelist : public net::ct::EVCertsWhitelist {
// was valid, false otherwise.
bool IsValid() const override;
+ // Returns the version of the whitelist in use, if available.
+ base::Version Version() const override;
+
protected:
~PackedEVCertsWhitelist() override;
@@ -67,6 +72,7 @@ class PackedEVCertsWhitelist : public net::ct::EVCertsWhitelist {
// shows that bsearch is about twice as fast as std::set lookups (and std::set
// has additional memory overhead).
std::vector<uint64_t> whitelist_;
+ base::Version version_;
DISALLOW_COPY_AND_ASSIGN(PackedEVCertsWhitelist);
};
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/net/packed_ct_ev_whitelist.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698