Certificate Transparency: Adding finch and NetLog logging for EV certs

chrome/browser/resources/net_internals/log_view_painter.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(eroman): put these methods into a namespace.
 
 var createLogEntryTablePrinter;
 var proxySettingsToString;
 var stripCookiesAndLoginInfo;
 
@@ skipping 263 matching lines @@
     case EventType.HTTP_TRANSACTION_SEND_REQUEST_HEADERS:
     case EventType.HTTP_TRANSACTION_SEND_TUNNEL_HEADERS:
       return writeParamsForRequestHeaders;
 
     case EventType.PROXY_CONFIG_CHANGED:
       return writeParamsForProxyConfigChanged;
 
     case EventType.CERT_VERIFIER_JOB:
     case EventType.SSL_CERTIFICATES_RECEIVED:
       return writeParamsForCertificates;
+    case EventType.EV_CERT_CT_COMPLIANCE_CHECKED:
+      return writeParamsForCheckedEVCertificates;
 
     case EventType.SSL_VERSION_FALLBACK:
       return writeParamsForSSLVersionFallback;
   }
   return null;
 }
 
 /**
  * Default parameter writer that outputs a visualization of field named |key|
  * with value |value| to |out|.
@@ skipping 284 matching lines @@
   }
 
   // Strip the trailing CRLF that params.line contains.
   var lineWithoutCRLF = params.line.replace(/\r\n$/g, '');
   out.writeArrowIndentedLines([lineWithoutCRLF].concat(params.headers));
 
   consumedParams.line = true;
   consumedParams.headers = true;
 }
 
+function writeCertificateParam(entry, out, consumedParams, paramName) {
+  var certs = entry.params[paramName].certificates.reduce(
+      function(previous, current) {
+        return previous.concat(current.split('\n'));
+      }, new Array());
+  out.writeArrowKey(paramName);
+  out.writeSpaceIndentedLines(8, certs);
+  consumedParams[paramName] = true;
+}
+
 /**
  * Outputs the certificate parameters of |entry| to |out|.
  */
 function writeParamsForCertificates(entry, out, consumedParams) {
   if (entry.params.certificates instanceof Array) {
     var certs = entry.params.certificates.reduce(function(previous, current) {
       return previous.concat(current.split('\n'));
     }, new Array());
     out.writeArrowKey('certificates');
     out.writeSpaceIndentedLines(8, certs);
     consumedParams.certificates = true;

[mmenke, 2014/12/16 16:40:12]

This can use writeCertificateParam, too, I believe.

[Eran Messeri, 2014/12/17 16:19:31]

Not quite - this one takes the certificates from entry.params.certificates while
the others take it from entry.params.something.certificates. I've made a slight
change to accommodate both cases.

   }
 
   if (typeof(entry.params.verified_cert) == 'object') {
     if (entry.params.verified_cert.certificates instanceof Array) {
-      var certs = entry.params.verified_cert.certificates.reduce(
-          function(previous, current) {
-        return previous.concat(current.split('\n'));
-      }, new Array());
-      out.writeArrowKey('verified_cert');
-      out.writeSpaceIndentedLines(8, certs);
-      consumedParams.verified_cert = true;
+      writeCertificateParam(entry, out, consumedParams, 'verified_cert');
     }

[mmenke, 2014/12/16 16:40:12]

nit:  Don't use braces on single line if's (x2)

[Eran Messeri, 2014/12/17 16:19:31]

Done and done.

   }
 
   if (typeof(entry.params.cert_status) == 'number') {
     var valueStr = entry.params.cert_status + ' (' +
         getCertStatusFlagSymbolicString(entry.params.cert_status) + ')';
     out.writeArrowKeyValue('cert_status', valueStr);
     consumedParams.cert_status = true;
   }
 
 }
 
+function writeParamsForCheckedEVCertificates(entry, out, consumedParams) {
+  if (typeof(entry.params.certificate) == 'object') {
+    if (entry.params.certificate.certificates instanceof Array) {
+      writeCertificateParam(entry, out, consumedParams, 'certificate');
+    }
+  }
+}
+
 /**
  * Outputs the SSL version fallback parameters of |entry| to |out|.
  */
 function writeParamsForSSLVersionFallback(entry, out, consumedParams) {
   var params = entry.params;
 
   if (typeof params.version_before != 'number' ||
       typeof params.version_after != 'number') {
     // Unrecognized params.
     return;
@@ skipping 133 matching lines @@
   }
 
   if (config.source != undefined && config.source != 'UNKNOWN')
     result.push('Source: ' + config.source);
 
   return result.join('\n');
 };
 
 // End of anonymous namespace.
 })();